The section-heading-first-child custom a11y test is too strict

Description

In edx-custom-a11y-rules, we have a section-heading-first-child test that makes sure that a <section> is immediately followed by a <hX> element.

But it's oddly defined. I think it should allow intermediate <div> or <hgroup> wrappers between the section and the <hX> element.

It currently only allows (in css selector terms):

That is, it allows an immediate h1 with no intermediaries except an optional header element.

But is it actually bad if div elements are in the heirarchy? Like <section><div><h1>...</h1></div></section>. This often happens in real code (just ran into it).

https://github.com/edx/edx-custom-a11y-rules/blob/master/lib/custom_a11y_rules.js#L218

Other notes

Activity

Show:
skool beep
April 15, 2021, 6:15 AM

skoolbeep

Students can join the online classes through the integrated time table from their mobile devices using SkoolBeep iOS and Android apps

VIEW MORE

kalyan jewellers
April 12, 2021, 9:05 AM

We are one of the oldest business families in India with a family legacy of 112 years in business. Started for the noble cause of nation-building and self-sustenance in a pre-independent India, the forefathers believed ethical, honest and transparent business practices should form the foundation of the group.

Having ventured into jewellery retailing in 1993 in Thrissur, Kerala, India, where we are headquartered, and as on June 30, 2020, we have 137 showrooms spread across India and GCC

VIEW MORE

  • MORE THAN140STORES

  • OVER100YEARS IN TRADE

  • MORE THAN10BRANDS



pagal world
April 11, 2021, 4:15 PM

lut gaye song download pagalworld

lut gaye song download

lut gaye mp3 song download

Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Unassigned

Reporter

Michael Terry