Updates to frontend-auth and frontend-app-payment to reduce false errors

Description

  • In frontend-auth some errors are getting processed by processAxiosError twice. Figure out why and stop this from happening.

  • The payment page is making requests to fetch basket even if the user is not logged in (during the time between loging_refresh failure and redirect). Stop it from making these requests if ensureAuthenticatedUser fails.

  • Add retry logic to login_refresh and csrf token refresh to help reduce Network error problems. Use exponential backoff.

Activity

Show:
Adam Butterworth
March 2, 2020, 5:08 PM

Agreed.

Robert Raposa
March 2, 2020, 4:52 PM

Should we just close this ticket? That’s what I would propose.

Adam Butterworth
March 2, 2020, 3:44 PM

I’m not sure..

1 - pretty sure we addressed this and logs on profile and payment look pretty clean
2 - I don’t know
3 - we have some retry logic working but it’s not as robust as it could be. probably not worth the time though

 

Robert Raposa
March 2, 2020, 3:26 PM

: This ticket includes 3 different issues. Do you know which are still valid? Seems like the middle one should move to Revenue if it is still an issue?

Epic Link

None

Story Points

None

Assignee

Adam Butterworth

Reporter

Adam Butterworth

Labels

None

Sprint