Too many elements and interactive features nested in Heading element.
Location: 05 Course - Peer Assessment
Description: The headings used for each step includes the button to expand it, the text below it and the Status on the right side. When the heading contains the entire block, each element is rendered as heading level 4 with a screen reader which may be confusing to understand the structure of the page
Auditor Note: Developers must ensure the proper text is implemented as a heading. In this case, only the title of that section should be a heading. The text indicating the status and the text for the due date should be rendered as static text. In addition, this would help with the label of the button as well since currently the label is rendered as the section title and the due date text which is long.
<button aria-describedby="deadline status" class="ui-slidable" aria-expanded="false" id="oa_response..." aria-controls="oa_response_block-v1...">
...<span class="step__label">Your Response</span>
<span id="deadline" class="date ora-datetime" ...>due Jan 1, 2029 00:00 GMT (in 11 years, 4 months)</span>
<span id="status" class="step_status_value"><
Internal Note: I agree with this assessment. Can we get these status indicators outside of the Heading element?
Pull the button element outside of the h4 element.
Add an aria-labeledby attribute to the button pointing at the title
Add an id to the title element (the deepest one, containing the actual text of the assessment step - e.g. "Your Response")
Add a caret icon to the button, make this the main control (see screenshots below).
Add an aria-describedby attribute to the step__title elements pointing at the deadline and status
We have to add ids to the status and deadline elements for this attribute to point to.
Do the above for all of the appropriate templates in the response, peer, grade, and self directories (these correspond to each of the different steps available for an open response assessment).
Follow the guide here to clone the ora2 repo locally: https://openedx.atlassian.net/wiki/spaces/EDUCATOR/pages/9765004/ORA+Developer+Guide
Check out work branch from lms shell and then pip install it, create virtualenv, activate it, run make install
Use the Demo course in your devstack
Steps to Reproduce
Reason for Variance
User Impact Summary
Sandbox is ready now, check the ORA problems in the demo course: https://iloveagent57.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/courseware/graded_interactions/175e76c4951144a29d46211361266e0e/?activate_block_id=block-v1%3AedX%2BDemoX%2BDemo_Course%2Btype%40sequential%2Bblock%40175e76c4951144a29d46211361266e0e
This is ready for review again. I'm updating a sandbox with my ORA branch now, will ping when it's ready for viewing.
Just a status note: things are moving along and looking ok when the assessment is "in progress":
There's still all of the self assessment step to deal with, and the styling is off under the peer assessment step when we're in the "not started" state: