Disable combined Upload & Submit step in ORA

Description

Bug Description:
I discovered this behavior while trying to repro a different bug.

  1. Create an ORA with optional file uploads and text response.

  2. Click "Choose Files" and select a file that will cause an upload error. Example: A file named tęšt-fïłê.jpg will raise an error when being uploaded.

  3. Put in a description, but don't click "Upload Files", click "Submit your response and move to the next step".

  4. Click yes on all JS alerts.

  5. An error banner will appear when attempting to upload files, but just wait

  6. Your submission will be created, but the file you uploaded will not appear, showing you as having an effectively blank submission. (clarification: your submission will contain info for the file, but since it was not uploaded, it won’t show up anywhere.)

Proposed Fix (AC):
The submission should wait for the upload. If the upload fails, we should not proceed with the submission.

Separate the Submit/Upload behavior into 2 discrete steps, as proposed by :

  • Staging file(s) (user has clicked Choose files… and selected files but are awaiting description/upload) should disable the submit button.

  • After a student clicks Upload, a successful upload re-enables the submit button (if all required sections are complete).

  • After a failed/partial failed upload, [open discussion for what we want to do here]

  • Remove the “shortcut” where clicking the Submit button while a file has been staged uploads the file before submitting.

  • Update alert text/messaging/documentation with new behavior

Steps to Reproduce

None

Current Behavior

None

Expected Behavior

None

Reason for Variance

None

Release Notes

None

User Impact Summary

None

Activity

Show:
Nathan Sprenkle
February 11, 2021, 4:18 PM

Nathan Sprenkle
January 19, 2021, 10:46 PM

Changed title from Error handling around combined upload/submit allows effectively empty submissions

Nathan Sprenkle
December 10, 2020, 7:53 PM

Outstanding question for and , on a failed file upload should we:

  1. automatically disable the submit button until successful re-upload
    argument: I wanted to upload a file, why would it make sense to be able to submit without it and end up with a partial submission?
    workaround: student reloads page, if the submission doesn’t require files or they don’t want to add the one that fails, they can still submit

  2. fall back to existing validation
    argument: as long as a submission does not require files, or at least one file successfully uploaded, don’t block the student from submitting

Jansen Kantor
December 10, 2020, 7:37 PM

It was where I found it, though, this was my first thought as to the cause of that ticket

Jansen Kantor
December 10, 2020, 7:35 PM

It actually /isn’t/ the cause of that ticket. In this case, the submission is created with the file info for the nonexistant file. In that ticket, the submission was completely blank.

Done

Assignee

Nathan Sprenkle

Reporter

Jansen Kantor

Labels

Reach

None

Impact

None

Platform Area

None

Customer

None

Partner Manager

None

URL

None

Contributor Name

None

Groups with Read-Only Access

None

Story Points

3

Actual Points

None

Category of Work

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Sprint

None

Priority

Unset