Details

    • Type: Task
    • Status: Done
    • Priority: Unset
    • Resolution: Done
    • Labels:
      None

      Description

      Help prepare edx-platform for python3 by doing the following:

      1. Comment on the ticket to indicate that you are starting work on it.
      2. Launch a development shell in a Docker container via either "make shell" or devstack's "make lms-shell". Alternatively, you can create a new virtualenv or conda environment and install modernize and isort into it (this is a better choice on Windows).
      3. run
        python-modernize -w lms/djangoapps/courseware/management/commands/import.py lms/djangoapps/courseware/management/commands/__init__.py lms/djangoapps/courseware/management/__init__.py lms/djangoapps/courseware/courses.py lms/djangoapps/courseware/models.py lms/djangoapps/courseware/middleware.py lms/djangoapps/courseware/admin.py lms/djangoapps/courseware/date_summary.py lms/djangoapps/courseware/context_processor.py lms/djangoapps/courseware/course_tools.py
        
      4. run
        isort -rc lms/djangoapps/courseware/management/commands/import.py lms/djangoapps/courseware/management/commands/__init__.py lms/djangoapps/courseware/management/__init__.py lms/djangoapps/courseware/courses.py lms/djangoapps/courseware/models.py lms/djangoapps/courseware/middleware.py lms/djangoapps/courseware/admin.py lms/djangoapps/courseware/date_summary.py lms/djangoapps/courseware/context_processor.py lms/djangoapps/courseware/course_tools.py
        
      5. Make sure the changes look reasonable and submit them as a pull request; mention this ticket in the description and include INCR-<Ticket Number> in the name.
      6. Ask for tests to be triggered if they don't start automatically.
      7. Diagnose any test failures caused by the changes, and either fix them or ask for help.
      8. If you run into unexpected errors, see this document for common problems: https://openedx.atlassian.net/wiki/spaces/AC/pages/977666218/Using+python-modernize+effectively

        Attachments

          Activity

            People

            • Assignee:
              ayubkhan Ayub Khan
              Reporter:
              feanil Feanil Patel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: