Search for "?" fails

Description

https://dev.edx.org/course?search_query=%3F doesn't load. It should load, even if it loads the no results view.
Acceptance Criteria

  • Make sure search term "?" and other strange search terms return proper results. In the case of "?", it should return no matching results. Just like the term "ayub"

Epic Link

Activity

Show:
Uzair Rasheed
August 1, 2017, 12:40 PM

Our edX marketing codebase is fine.It sends the user query(same as typed in the search bar) to the Backbone and replacement occurs in the JQuery. In an hour, i am going to make a PR for it and I will let you know about it.

fyi:

ClintonB
August 1, 2017, 11:39 AM

Where in the edX codebase does this happen? We shouldn't be digging through the source of jQuery.

Uzair Rasheed
August 1, 2017, 9:50 AM

if we make a call after encoding the search query then our marketing search doesn't halt. I am verifying it by encoding different inputs.
below is the code where replacement happens:
https://github.com/jquery/jquery/blob/c18d608537d8945de6c5855a9475657177fa74ac/src/core.js#L204

ClintonB
July 31, 2017, 8:21 PM

Where is the text being converted to a timestamp? It seems that is where the solution lies. Adding branching for special characters is unsustainable. The front-end should pass the user input directly to the backend.

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Priority

CAT-4

Assignee

Uzair Rasheed

Story Points

2

Reporter

ClintonB