Exclude archived runs on program details page if upgradeable runs present

Description

We were a little too ham-handed with the change in the linked ticket, and need to ensure that we only show the archive run if it is the ONLY run present.

We will likely need to revert most of the JS changes done on this PR:
https://github.com/edx/edx-mktg/pull/1406/files#diff-4bc02f80c98327e78f1b7e4e2cc57698

Example:
https://www.edx.org/micromasters/columbiax-artificial-intelligence

Steps to Reproduce

None

Current Behavior

None

Expected Behavior

None

Reason for Variance

None

Release Notes

None

User Impact Summary

None

Activity

Show:
Simon Chen
July 13, 2017, 3:48 PM

Please take note of this work by Mike. I think this is a requirement miss from

Ayub Khan
July 13, 2017, 5:16 PM

so what i understand from this ticket if there are multiple course runs we should not show any course run if all are expired. or this code is showing all course_runs which are expired. can you share a example or error.

Mike Dikan
July 13, 2017, 5:43 PM
Edited

Sure - I think this is what the 2nd acceptance criteria on was trying to cover. If there are ANY enrollable/upgradable/verifiable course runs, we should not use the archived course in the horizontal course run display.

This program shows the issue:
https://www.edx.org/micromasters/columbiax-artificial-intelligence

The top 2 course runs are still upgradeable and the bottom two course runs are archived. We should be showing the next course run for the bottom two courses.

I'll add a screenshot in case i fix this before EOD.

Ayub Khan
July 19, 2017, 7:42 AM

i just had a look at the pr and can not understand how this is related to LEARNER-695.

Matthew Medvedev-Piatetsky
July 19, 2017, 12:50 PM

it had to do with the course run level filtering removed in the discovery_card_horizontal_view, but I have put that back

Fixed

Assignee

Matthew Medvedev-Piatetsky

Reporter

Mike Dikan

Labels

Reach

None

Impact

None

Platform Area

None

Customer

None

Partner Manager

None

URL

None

Contributor Name

None

Groups with Read-Only Access

None

Actual Points

None

Category of Work

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Story Points

1

Sprint

None

Priority

CAT-2
Configure