Loading fonts twice on marketing site

Description

In a performance analysis of edx.org (https://gtmetrix.com/reports/www.edx.org/masAP58b) it was noticed that we are making multiple calls to load fonts

Serve resources from a consistent URL
The following resources have identical contents, but are served from different URLs. Serve these resources from a consistent URL to save 1 request(s) and 11.9KiB.

https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700
https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700,

I believe this is due to us loading fonts from both css(https://github.com/edx/edx-mktg/blob/c5d728a4d7134ebd66e9e016c8e7de11da807923/docroot/sites/all/themes/atedx/scripts/react/components/site_header/SiteHeader.jsx#L96-L100) and from (https://github.com/edx/edx-mktg/blob/c5d728a4d7134ebd66e9e016c8e7de11da807923/docroot/sites/all/themes/adaptivetheme/at_core/inc/fonts.inc)

Steps to Reproduce
Run a performance scan on edx.org at https://gtmetrix.com/reports/www.edx.org/masAP58b

Current Behavior
Calling to google api twice

Expected Behavior
Call only once or have a consistent url

Steps to Reproduce

None

Current Behavior

None

Expected Behavior

None

Reason for Variance

None

Release Notes

None

User Impact Summary

None

Activity

Show:
Raees Chachar
November 27, 2018, 7:22 AM

This is done https://github.com/edx/edx-bootstrap/pull/30 with release 1.0.2, https://github.com/edx/edx-bootstrap/releases. Need to discuss the version bump on edx-platform with

FYI:

Raees Chachar
November 28, 2018, 7:39 AM

Created https://openedx.atlassian.net/browse/DEVOPS-8057. Blocked till that is done.
cc:

Farhanah Sheets
December 6, 2018, 1:47 PM

noticed this had a hiccup with releasing to npm, is that still a blocker here? I saw the original PR was merged and the devops ticket closed, unsure if there is additional support that is needed on this one?

Raees Chachar
December 6, 2018, 4:31 PM

I should have added a task, we decided to update the travis file so we don't have to manually update NPM every time. https://github.com/edx/edx-bootstrap/pull/31 is the PR link. I got a reply on it, so it won't be blocked anymore. Thank you

Farhanah Sheets
December 6, 2018, 9:57 PM

Got it - thanks for the context!

Fixed

Assignee

Raees Chachar

Reporter

Zachary Rockwell

Reach

None

Impact

None

Platform Area

None

Customer

None

Partner Manager

None

URL

None

Contributor Name

None

Groups with Read-Only Access

None

Actual Points

None

Category of Work

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Story Points

3

Epic Link

Components

Priority

CAT-4
Configure