PHP 7 support for Current Marketing sites

Description

As a developer, We should make sure our systems work reliably in production and there is no downtime for our users.
Acceptance Criteria

Epic Link

None

Activity

Show:
Albert (AJ) St. Aubin
September 27, 2018, 10:59 AM

Lets leave this open while we wait on people to test.

Albert (AJ) St. Aubin
September 26, 2018, 5:31 PM

Email I just sent

Hello all,

The Spartans team has been working for the past few weeks on getting us ready for an October 1st mandatory upgrade to PHP 7.0 on our Drupal sites. Currently we are testing changes on the acceptance environment and are hoping to have these changes on Stage tomorrow. I am looking for as many people as possible to look at the Stage site for things that stop working after the upgrade to PHP 7.0, and currently work in production.

This email is a heads up email. I plan to send another when we have a more concise timeline.

Please let me know if you think you might be able to spend 30 minutes or so making sure the upgrade does not break your favorite part of the Marketing Site experience.

Thank you as always,
AJ

Albert (AJ) St. Aubin
September 26, 2018, 5:27 PM

Ok, I will send out a precursor email once we have a status update and confirmation we are ready to move to Stage.

Then once on Stage I will try and get people to help with testing for 30 or so minutes in the morning.

Mike Dikan
September 26, 2018, 5:24 PM

- I can help, but I think this is important enough that we should circulate more widely. This should be more of an all-hands-on-deck testing, especially for stage and prod release.

- fast 404 runs conditionally - I THINK it is mostly for static assets (js files, images, css, etc) but the way to test is to check the headers and the response. Note that we set different headers for fast_404 delivered responses:
https://github.com/edx/edx-mktg/blob/4e3b18a6ad7e2a5b3a048d354f2fef56df0b474d/docroot/sites/all/modules/contrib/fast_404/fast_404.inc#L245

Also note that fast_404 responses don't have the whole drupal look and feel as a rendered page:

fast_404:
https://acceptance.edx.org/asdhfugh.png (check headers)
not fast_404:
https://acceptance.edx.org/asdhfugh (check headers)

I'm pretty sure we customized this module, so we will need to be careful when we upgrade it and make sure we DON'T lose our local changes (which I think may be limited to the .inc file I linked above, but not sure)

Adeel Khan
September 26, 2018, 5:07 PM

Yes its already running on acceptance. Now as fast_404 is essential, i need to upgrade that module too as it has deprecated mysql_* calls which would fail in PHP 7. Iam upgrading it to 7.x-1.4 (mysqli_* based) instead of latest one 7.x-1.5 (PDO based). I can't ssh into acceptance to know if both php extensions are enabled or not.
Secondly how can one invoke this fast_404 module? Does any incorrect url would work?

Mostly i am worried about custom/contrib modules. If we can somehow invoke them to verify that they work under php 7 . I don't know much about these modules and at what time/page what modules are invoked.

Fixed
Your pinned fields
Click on the next to a field label to start pinning.

Priority

CAT-2

Assignee

Adeel Khan

Reporter

Ahsan Haq