Fix RoboGuice injection issues

Description

RoboGuice was integrated in https://github.com/edx/edx-app-android/pull/273

But many injections are not set up properly, so they cause null pointer exceptions. These are swallowed by our numerous generic exception catchers. We need to check and verify the whole implementation.

Steps to Reproduce

None

Reason for Variance

None

Release Notes

None

Activity

Show:
IbraheemZ
September 17, 2015, 12:24 PM
Nimisha Asthagiri
September 11, 2015, 2:34 PM

Thanks .

IbraheemZ
September 11, 2015, 1:32 PM

I'll take a quick test throughout the app and then close this after completing a few other issues I'm working.

Nimisha Asthagiri
September 10, 2015, 9:20 PM

Can we close this ticket? What remaining items are still issues?

IbraheemZ
September 3, 2015, 11:39 AM
Edited

I think the ServiceManager is not injected properly in TranscriptDownloader, which I think was where I encountered the issue.

How do we intend to "check and verify the whole implementation"?

Either go through the whole application checking for error reports in the LogCat, or check all the usages of the @Inject annotation and verify that it is set up properly. More generically, we need to get rid of the generic exception catch blocks implemented everywhere, as they swallow all the issues. However, if the QA pass doesn't turn up any issues, then we can probably go ahead with the release.

Your pinned fields
Click on the next to a field label to start pinning.

Assignee

IbraheemZ

Reporter

IbraheemZ

Labels