Android - Assessment - Download only on WiFi header shows on non video block.

Description

Actual Result:
Download only on WiFi header shows on non video block.

Expected Result:
No header message should appear in non video block.

Steps to Reproduce

1) Disable wifi.
2) Tap to select any course.
3) Tap to open any section that contains a video unit and a non video unit.
4) Tap on non video unit and view.

Reason for Variance

None

Release Notes

None

Activity

Show:
Mian Khalid
December 1, 2015, 12:45 PM
Edited

My PR fixes the said issue in the ticket but UX-wise the screen and this whole error-message don't look good.

Ref the attached video:

Following things don't look nice:

  1. The showing/hiding of error message causes the video player block and its message below to move down.

  2. While showing/hiding of error message empty white space can be seen during animation.

  3. Offline Mode red bar doesn't look cool.

thoughts ?

LeslieG
December 1, 2015, 10:05 PM

can you help with numbers 1 and 2? For number 3, that matches the design spec we have, so I wouldn't address. We have future plans to clean up our alerting bars and mechanisms throughout the app.

Christopher Lee
December 2, 2015, 3:56 PM

Should 1 and 2 be a separate ticket?

akivaR
December 2, 2015, 7:13 PM

On iOS we:
1, 2. Show the message in an overlay. Since the content isn't accessible anyway, there's no reason not to cover it up.
3. Don't show the offline mode header on individual content blocks. It's not useful since we don't show any of that content offline anway. (honestly I don't think we need the offline mode UI at all, but that's a separate thing).

Mirza Mubashar Baig
December 8, 2015, 12:55 PM

Fixed

Done

Assignee

Mian Khalid

Reporter

Mirza Mubashar Baig

Labels

Customer

None

URL

None

Groups with Read-Only Access

None

Actual Points

None

Reach

None

Impact

None

Open edX Discourse Thread

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Contributor Name

None

Blended Project Status Page

None

edX Squad

None

Product Rollout Framework

None

Content & Partner Success Lead

None

Marketing Lead

None

Learning Lead

None

Support Lead

None

Story Points

2

Epic Link

Sprint

None

Fix versions

Priority

CAT-2
Configure