Android - Assessment - Download only on WiFi header shows on non video block.
Download only on WiFi header shows on non video block.
No header message should appear in non video block.
Steps to Reproduce
1) Disable wifi.
2) Tap to select any course.
3) Tap to open any section that contains a video unit and a non video unit.
4) Tap on non video unit and view.
Reason for Variance
On iOS we:
1, 2. Show the message in an overlay. Since the content isn't accessible anyway, there's no reason not to cover it up.
3. Don't show the offline mode header on individual content blocks. It's not useful since we don't show any of that content offline anway. (honestly I don't think we need the offline mode UI at all, but that's a separate thing).
Should 1 and 2 be a separate ticket?
can you help with numbers 1 and 2? For number 3, that matches the design spec we have, so I wouldn't address. We have future plans to clean up our alerting bars and mechanisms throughout the app.
My PR fixes the said issue in the ticket but UX-wise the screen and this whole error-message don't look good.
Ref the attached video:
Following things don't look nice:
The showing/hiding of error message causes the video player block and its message below to move down.
While showing/hiding of error message empty white space can be seen during animation.
Offline Mode red bar doesn't look cool.