iOS - Don't need the users dictionary in case of PATCH calls

Description

As per comment in MA-2542:

We don't need the users dictionary in case of PATCH calls, and the client end should handle this case by itself i.e. using the already fetched users dictionary.
Incase of POST, we should store the logged in user's profile info and show the picture accordingly (if available).

Steps to Reproduce

None

Reason for Variance

None

Release Notes

None

Activity

Show:
Mirza Mubashar Baig
August 25, 2016, 9:57 AM

Its mentioned in comments on ticket https://openedx.atlassian.net/browse/MA-2542.

Christopher Lee
August 25, 2016, 1:08 PM
Edited

https://openedx.atlassian.net/browse/MA-2542 is a server-side ticket that we never implemented.so iOS would not have been able to implemented in said way.

Could you confirm?

Christopher Lee
September 7, 2016, 2:44 PM

Can you post a follow up on my previous comment/question?

Verdan Mahmood
September 7, 2016, 4:26 PM

for iOS we were not handling this issue properly, and suggested that instead of changing the code in the API, we'll fetch the user's information from server. But later on after discussion on Khalid's PR we decided not to call the user's information from server, instead use the existing user information that we have in the app.
This ticket is just to make sure we use existing user information in case of creating a new post.

had some concerns that there might be a time when user information API won't work properly because of internet connection, then we won't have user data to create a new post. (although this is very rare, but we wanted to handle each corner case). To tackle this issue we decided that if we don't have user data then call the user profile API before creating a new post. because either way, we need to have logged in user data in the app. By doing so, we'll have the user data for the next post or other operations.

Mirza Mubashar Baig
May 4, 2017, 11:54 AM

Verified.

Fixed

Assignee

Saeed Bashir

Reporter

Mirza Mubashar Baig

Customer

None

URL

None

Groups with Read-Only Access

None

Actual Points

None

Reach

None

Impact

None

Open edX Discourse Thread

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Contributor Name

None

Blended Project Status Page

None

edX Squad

None

Product Rollout Framework

None

Content & Partner Success Lead

None

Marketing Lead

None

Learning Lead

None

Support Lead

None

Story Points

2

Sprint

None

Priority

Unset
Configure