Android - Screen Toggled event is firing when it is not supposed to be
Description
The Screen Toggled event is only supposed to fire when the fullscreen button is clicked. Instead it will fire whenever the video player calls a common method called exitfullscreen().
Acceptance Criteria:
Play any video in the app:
Press enter full screen button, screen toggled event should be fired.
In full screen mode, press exit full screen button, screen toggled event should be fired.
Screen toggled event should not be fired in any other case/possible scenario.
Steps to Reproduce
Reason for Variance
Release Notes
Activity
Here is the name and bi event for Screen Toggled event.
name: "Screen Toggled"
bi_name: "edx.bi.video.screen.fullscreen.toggled"
As explained from toggle word we should fire this event when screen will be toggled to enter full screen or exit from full screen just like happening currently on both iOS and Android side.
What are your thoughts on it, or should we change it to fire only in case if user enter into full screen.
cc:
This event is being fired anytime the exitfullscreen() method is called, which is being used for cases besides a user clicking on the toggle button.
This ticket is to only have the event fire when the user explicitly hits the toggle button rather than anytime the screen exits out of fullscreen via the exitfullscreen() method.
Got clear now, thanks for explanation!
ready for QA.
Verified.
Assignee
Reporter
Labels
Customer
URL
Groups with Read-Only Access
Actual Points
Reach
Impact
Open edX Discourse Thread
Platform Map Area (Levels 1 & 2)
Platform Map Area (Levels 3 & 4)
Contributor Name
Blended Project Status Page
edX Squad
Product Rollout Framework
Content & Partner Success Lead
Marketing Lead
Learning Lead
Support Lead
Story Points
Sprint
Priority
