Android - Screen Toggled event is firing when it is not supposed to be

Description

The Screen Toggled event is only supposed to fire when the fullscreen button is clicked. Instead it will fire whenever the video player calls a common method called exitfullscreen().

Acceptance Criteria:
Play any video in the app:

  • Press enter full screen button, screen toggled event should be fired.

  • In full screen mode, press exit full screen button, screen toggled event should be fired.

  • Screen toggled event should not be fired in any other case/possible scenario.

Steps to Reproduce

None

Reason for Variance

None

Release Notes

None

Activity

Show:
Farhan Khan
March 29, 2017, 10:53 AM
Edited


Here is the name and bi event for Screen Toggled event.

name: "Screen Toggled"
bi_name: "edx.bi.video.screen.fullscreen.toggled"

As explained from toggle word we should fire this event when screen will be toggled to enter full screen or exit from full screen just like happening currently on both iOS and Android side.

What are your thoughts on it, or should we change it to fire only in case if user enter into full screen.

cc:

Christopher Lee
March 29, 2017, 2:30 PM

This event is being fired anytime the exitfullscreen() method is called, which is being used for cases besides a user clicking on the toggle button.

This ticket is to only have the event fire when the user explicitly hits the toggle button rather than anytime the screen exits out of fullscreen via the exitfullscreen() method.

Farhan Khan
March 29, 2017, 3:07 PM

Got clear now, thanks for explanation!

Farhan Khan
April 10, 2017, 11:35 AM

ready for QA.

Mirza Mubashar Baig
April 10, 2017, 2:30 PM

Verified.

Done

Assignee

Farhan Khan

Reporter

Christopher Lee

Labels

Customer

None

URL

None

Groups with Read-Only Access

None

Actual Points

None

Reach

None

Impact

None

Open edX Discourse Thread

None

Platform Map Area (Levels 1 & 2)

None

Platform Map Area (Levels 3 & 4)

None

Contributor Name

None

Blended Project Status Page

None

edX Squad

None

Product Rollout Framework

None

Content & Partner Success Lead

None

Marketing Lead

None

Learning Lead

None

Support Lead

None

Story Points

0.5

Sprint

None

Priority

Unset
Configure