Entire footer should be configured
Strings should be translated
– I went ahead and checked out the branch and tested out the functionality. See "additional-footer.png" for the new feature and "default-footer.png" for our typical non-augmented footer. I have no problem with the functionality, but as we noted earlier, there are concerns. The blockers being:
Can these be translated from within a setting?
Can the solution be generalized?
I'd like to suggest the author update the PR so that the footer as a whole could be configured, but don't have good idea for how to make the footer a setting and translatable.
& might have some insights into translations from within a settings file.
would you classify this as an addition to theming?
If theming was supported in Insights... yes. At the moment, however, we need to find another mechanism for making it generic.