WIP: Resolve issue with devstack_docker not loading comprehensive theming DIR paths for mako template files.

Description

*NOTE:* This is WIP. I created this to discuss with edX best ways to handle this since I'm new to how `derive_settings` works when setting up DIRS for Mako templates for comprehensive theming. I came across this issue when trying to setup comprehensive theming in new directory for the `open-release/hawthorn.master` release under devstack_docker configuration.

*Background:* It appears that when running docker_devstack Django configuration that the derived settings for Django Mako DIRS when calling `make_mako_template_dirs` does not setup the `COMPREHENSIVE_THEME_DIRS` path correctly when calling the `_derive_settings(name_)` call at the end of `lms/envs/production.py` since the Django setting for `ENABLE_COMPREHENSIVE_THEMING` is set to `False`. @doctoryes mentions that this derive settings call should be handled at the end of the environment settings configuration after all settings have been set. Since `lms/envs/devstack.py` includes `lms/envs/production.py` this pull request changes the `derive_settings` call to be handled after all configuration settings have been done for the devstack_docker environment; other Django environment settings keep `derive_settings` inline with how it's done previously.

*Slack (#theming):* Initial discussion located at this thread https://openedx.slack.com/archives/C0G15M90X/p1545148298031200

*Studio Updates:* None. Should we be concerned about this as well? I'm thinking yes.

*LMS Updates:* Verify that comprehensive theming is working by overriding the `edx-platform/lms/static/images/logo.png` file and see if the graphic changes. This logo needs to reside in a separate DIR than the default configuration.

*Testing:* Update the following Django configuration settings by including a separate DIR for viewing theming within either `lms/envs/private.py` or `lms/envs/devstack_docker.py`file.
```

  1.  

    1.  

      1.  

        1.  

          1.  

            1.  

              1.  

                1.  

                  1.  

                    1.  

                      1.  

                        1.  

                          1.  

                            1.  

                              1.  

                                1.  

                                  1.  

                                    1.  

                                      1.  

                                        1.  

                                          1.  

                                            1.  

                                              1.  

                                                1.  

                                                  1.  

                                                    1.  

                                                      1.  

                                                        1.  

                                                          1.  

                                                            1.  

                                                              1.  

                                                                1. THEMING ################################

DEFAULT_SITE_THEME = 'themename'
ENABLE_COMPREHENSIVE_THEMING = True

  1. COMPREHENSIVE_THEME_DIR = ''
    COMPREHENSIVE_THEME_DIRS = [
    '/edx/app/edx-themes/edx-platform'
    ]
    ```

Assignee

Unassigned

Reporter

Open Source Pull Request Bot

Contributor Name

Zachary Trabookis

Repo

edx/edx-platform

Customer

None

Epic Link

None

OSCM Assignee

None

Platform Map Area (Levels 1 & 2)

Developer Experiences

Platform Map Area (Levels 3 & 4)

None

Blended Hour Utilization Percentage

None

Priority

Unset
Configure