This allows the variables to be used in the bootstrap and
non-bootstrap styles. The current implementation only adds the variables to `lms/static/sass/partials/theme/_variables-v1.scss` and the bootstrap styles cannot use the variables defined there because of the way the imports for the bootstrap styles work.
This PR moves the variable definition to a `common-variables.scss` in the theme folder which is imported both by `_variables-v1.scss` partial which allows the non-bootstrap styles to work and the `_lms-overrides.scss` partial which allows the bootstrap styles to work using the variables.
*JIRA tickets*: None
*Sandbox URL*: TBD - sandbox is being provisioned.
*Merge deadline*: None
Deploy a sandbox using the `simple-theme` role by defining some SASS variable overrides through the `SIMPLETHEME_STATIC_SASS_OVERRIDES`. Optionally define some custom SASS using the `SIMPLETHEME_EXTRA_SASS`. Verify that the variables which are used in both the bootstrap and non-bootstrap styles are overridden with the value provided for the variable(s) using the `simple-theme` role.
[ ] @giovannicimolin
[ ] edX reviewer(s) TBD
Configuration Pull Request
Make sure that the following steps are done before merging:
[ ] A DevOps team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
[ ] Are you adding any new default values that need to be overridden when this change goes live? If so:
[ ] Update the appropriate internal repo (be sure to update for all our environments)
[ ] If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
[ ] Add an entry to the CHANGELOG.
[ ] If you are making a complicated change, have you performed the proper testing specified on the [Ops Ansible Testing Checklist](https://openedx.atlassian.net/wiki/display/EdxOps/Ops+Ansible+Testing+Checklist)? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
[ ] Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?