Details

    • Type: Pull Request Review
    • Status: Merged
    • Priority: Unset
    • Resolution: Done
    • Affects versions: None
    • Fix versions: None
    • Labels:
    • Contributor Name:
      Mahyar Damavand
    • Repo:
      edx/edx-documentation
    • PR Number:
      1,840
    • Sprint:
    • Github Latest Action:
      issue_comment: created
    • Github Latest Action by edX:
      Yes
    • Github PR Last Updated By:
      natabene

      Description

      By this PR,
      1) A typo has been fixed. There is no `cs_comment_service_development`. indeed its name is `cs_comments_service_development` ( with an extra 's' after 'comment' ).
      2) A MySQL system database - `sys` - excluded from the list of databases being dumped.
      3) Adding `DROP TABLE IF EXISTS...` before `CREATE TABLE` commands is skipped out. as we have a drop database, adding them are pointless.

          1. Reviewers

      Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives :+1:.

      • [ ] Subject matter expert:
      • [ ] Subject matter expert:
      • [ ] Doc team review (sanity check, copy edit, or dev edit?): @edx/doc
      • [ ] Product review:
      • [ ] Partner support:
      • [ ] PM review:

      FYI: Tag anyone else who might be interested in this PR here.
      @nedbat

          1. Testing
      • [ ] Ran ./run_tests.sh without warnings or errors
          1. HTML Version (optional)
      • [ ] Build an RTD draft for your branch and add a link here
          1. Sandbox (optional)
      • [ ] Point to or build a sandbox for the software change and add a link here
          1. Post-review
      • [ ] Add a comment with the description of this change or link this PR to the next release notes task.
      • [ ] Squash commits

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              Open Source Pull Request Bot
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Github PR Last Updated At: