Update password reset subsite logo and show contact mailing address c…

Description

@pomegranited @jramnai I created this update to automatically update the comprehensive theming logos within the password reset emails and conditionally show the mailing address if defined in site configuration.

This is in response to https://discuss.openedx.org/t/how-to-change-edx-logo-and-sign-in-link-in-password-reset-email/172. I realize that you could also manually do this through template updates like the `red-theme` does here https://github.com/edx/edx-platform/tree/master/themes/red-theme/lms/templates/ace_common/edx_ace/common, however, I wanted this to be across all subsites without a theme update.

Let me know what you think about this change. The logo width was removed but height was left in be consistent across all subsites. This could change if we update the template pages for `ace_common` mentioned above though.

Activity

Show:
Waheed Ahmed
April 14, 2021, 7:28 AM

Sure, we will review it in our next grooming and will update it accordingly. Thank you!

Natalia Berdnikov
April 13, 2021, 5:00 PM

Author doesn’t have time to work on this. So if you are not interested or it is not worth investing your time to finish it on your own, please reject this PR.

Natalia Berdnikov
April 9, 2021, 2:15 PM

Let’s check with the author.

Waheed Ahmed
April 9, 2021, 10:57 AM

Seems like the contributor needs to address some changes requested by Omar, and PR also needs to be rebased with the latest master branch.

And there is also a concern from Nimisha related to the rebrand work done for the logos, I’m not sure if it’s ready for review until the contributor updates the PR.

Wajeeha Khalid
March 25, 2021, 10:59 AM

sure; I can pull this in our upcoming sprint.

Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Waheed Ahmed

Reporter

Open Source Pull Request Bot

Contributor Name

Zachary Trabookis

Repo

edx/edx-platform

Customer

Platform Map Area (Levels 1 & 2)

Developer Experiences - Platform Services

Github Lines Added

17

Github Lines Deleted

3