We're updating the issue view to help you get more done. 

Edx Notes tests failing on Firefox 57

Description

Reference for Bok Choy upgrade process: https://openedx.atlassian.net/wiki/spaces/TE/pages/567083109/Firefox+57+upgrade+for+Bok+Choy+tests

Description: As part of the Firefox upgrade on Jenkins, the following tests are failing, and need to be fixed

Error Msg:

1 BrokenPromise: Promise not satisfied: Adder is visible.

Stack trace

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 self = <common.test.acceptance.tests.lms.test_lms_edxnotes.EdxNotesDefaultInteractionsTest testMethod=test_can_create_notes> def test_can_create_notes(self): """ Scenario: User can create notes. Given I have a course with 3 annotatable components And I open the unit with 2 annotatable components When I add 2 notes for the first component and 1 note for the second Then I see that notes were correctly created When I change sequential position to "2" And I add note for the annotatable component on the page Then I see that note was correctly created When I refresh the page Then I see that note was correctly stored When I change sequential position to "1" Then I see that notes were correctly stored on the page """ self.note_unit_page.visit() components = self.note_unit_page.components > self.create_notes(components) common/test/acceptance/tests/lms/test_lms_edxnotes.py:196: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ common/test/acceptance/tests/lms/test_lms_edxnotes.py:135: in create_notes for note in component.create_note(".{}".format(self.selector)): common/test/acceptance/pages/lms/edxnotes.py:457: in create_note note.select_and_click_adder() ../../edx-venv/local/lib/python2.7/site-packages/bok_choy/page_object.py:122: in wrapper return method(self, *args, **kwargs) common/test/acceptance/pages/lms/edxnotes.py:542: in select_and_click_adder self.wait_for_adder_visibility() ../../edx-venv/local/lib/python2.7/site-packages/bok_choy/page_object.py:122: in wrapper return method(self, *args, **kwargs) common/test/acceptance/pages/lms/edxnotes.py:511: in wait_for_adder_visibility self._bounded_selector(self.ADDER_SELECTOR), "Adder is visible." ../../edx-venv/local/lib/python2.7/site-packages/bok_choy/page_object.py:630: in wait_for_element_visibility self.wait_for(lambda: self.q(css=element_selector).visible, description=description, timeout=timeout) ../../edx-venv/local/lib/python2.7/site-packages/bok_choy/page_object.py:573: in wait_for return EmptyPromise(no_selenium_errors(promise_check_func), description, timeout=timeout).fulfill() _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <bok_choy.promise.EmptyPromise object at 0x7f9910f06a10> def fulfill(self): """ Evaluate the promise and return the result. Returns: The result of the `Promise` (second return value from the `check_func`) Raises: BrokenPromise: the `Promise` was not satisfied within the time or attempt limits. """ is_fulfilled, result = self._check_fulfilled() if is_fulfilled: return result else: > raise BrokenPromise(self) E BrokenPromise: Promise not satisfied: Adder is visible. ../../edx-venv/local/lib/python2.7/site-packages/bok_choy/promise.py:106: BrokenPromise

Link to failing build: https://build.testeng.edx.org/job/edx-platform-test-subset/1100582

Tests Impacted:

acceptance.tests.lms.test_lms_edxnotes.EdxNotesDefaultInteractionsTest.test_can_create_note_with_tags
acceptance.tests.lms.test_lms_edxnotes.EdxNotesDefaultInteractionsTest.test_can_create_notes

Steps to Reproduce

None

Current Behavior

None

Expected Behavior

None

Reason for Variance

None

Release Notes

None

User Impact Summary

None

Status

Assignee

Mike Youngstrom

Reporter

Stuart Young

Reach

None

Impact

None

Customer

None

Partner Manager

None

URL

None

Contributor Name

None

Groups with Read-Only Access

None

Actual Points

None

Category of Work

None

Stakeholders

None

Sprint

None

Priority

CAT-3