Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Tickets not authored by 2U or tCRIL engineers go to this board when they come in

  • Once added to the board, it needs to get reviewed and merged

  • Use the board’s columns to change state of PR (can also change on the right side of the PR pages). The following guidelines should help determine appropriate status:

    • No Status is all PRs without a manually-assigned status. This is automatic grouping by the board, so all new OSPRs will go in there first. From there you pick them up and assign status.

    • Not ready: PR is still WIP/draft, or author is just not ready for whatever reason except CLA.

    • Ready for Review:

      • At a minimum the PR should not be a draft and should have a green CLA check.

      • Unless the PR introduces a large, impactful set of changes that requires input from more than one team (cf. above) all checks should be green/passing on it. (The idea is that we don’t want to waste reviewers' time on PRs that are half-baked – if checks are failing there is a chance that the author never resolves the issues and the PR ends up getting closed instead of merged.)

      • The author asked for review or confirmed that the PR is ready for review when prompted.

    • In Review: self-explanatory.

    • Blocked: TBD

      • PRs with missing CLAs (these might eventually get a separate column on the board)

      • PRs that are blocked by other work (e.g. PRs that need to be merged after some other PR or event, PRs that have been deprioritized by their authors in favor of other work, PRs that are waiting for funding or client input, etc.)

    • Done: PR has been merged or closed.

...