Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Time

Item

Presenter

Notes

<5 minutes

Design tokens update

https://github.com/openedx/frontend-build/pull/546

Merged! 🎉 First officially merged contribution towards supporting design tokens 👏

10-15 minutes

Navbar and FPF?

Brian Smith

10 minutes

Peer dependency on Paragon in @openedx/frontend-build?

Adam Stankiewicz

Context:

  • There is some forward-looking intent to “go build-less” in JS libraries, where dist would no longer exist. There are several code paths within ParagonWebpackPlugin that expect dist to exist.

  • ParagonWebpackPlugin also depends on a specific file, theme-urls.json within the installed @openedx/paragon.

[question/concern] How do we prevent instances that deploy to production from master from causing a regression when upgrading to a version of paragon/brand that no longer contains dist (e.g., buildless) or theme-urls.json (e.g., renamed)?

There could be risk in not properly catching an upgrade of @openedx/paragon (for example) that results in deploying an MFE with no CSS, as it would not throw any errors during build and likely not trigger alerts during monitoring, resulting in a largely unusable app without styles.

Notes:

  • Brian Smith Paragon is already a peer dep in frontend-base

  • Would adding @openedx/paragon within peerDependencies be an approach to handling this?Brian Smith note: Paragon is already a peer dep in frontend-base

    • Pros:

      • Should result in throwing an npm install or npm ci error during local development, if/when there are version incompatibilities.

    • Cons:

      • Introduces coupling that frontend-build must always be used alongside Paragon.

        • Similar to how frontend-platform must always be used alongside @openedx/frontend-build since env.config was introduced.

...