...
Before we ask dev teams to review our PRs, it's advantageous to review tickets internally first. In general, it's nice to tag someone who is familiar with the area of code that your PR touches. It's not necessary though. So, when you open a new PR, do the following:
- If you have a good idea of who to tag through git blame or previous knowledgeit's very obvious that someone should review the code, tag that person
- Otherwise, ask either in standup or in the escalation room of who would be good to review the PRrun this script to figure out whom you should tag:
View file name whomtotag.py height 250
I'd expect folks to tag 1 (max 2) internal reviewers before asking for a pull request from a team.
...