Versions Compared

Version Old Version 11 New Version Current
Changes made by

Kyle McCormick

Kyle McCormick

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  1. Better status communication (via GitHub checks?)

    • We need to be immediately notified when a sandbox rebuild has been triggered.

      • By corollary, a developer should understand that if NOTHING HAPPENS, then no sandbox is building, and no sandbox will build.

      • This should all be true even if the code or the sandbox configuration is completely messed up. Fail quickly and loudly!

    • At the same time, we do not want to overwhelm folks who are subscribed to the PR with notifications. 3 GitHub comments per push is not acceptable.

    • Proposed solution: As a replacement to the current PR comment… have the PR sandbox build create a GitHub status check, which shows the status of the build (pending, in progress, failed, success) and links out to a status page which includes:

      • the deployment logs,

      • links the deployment config, and

      • If successful, links to LMS, Studio, LMS admin and CMS admin.

      • [Stretch/Nice-to-have] Buttons to (a) update the sandbox and (b) destroy and recreate the sandbox. We realize that this may be significantly higher scope than the other items in the list… if so, then please do not spend too much discovery time on this rather than items 2-5.

      • Examples like the proposed solution: Netlify, Vercel

    • Whatever you come up with, we will want to continue to be able to view a list of existing sandboxes. Today, we can do this easily by searching the openedx org for the create-sandbox label. If the label remains, then this task is a no-op. If you get rid of the label, then we would need an alternative approach.

  2. More access

    • We need access to application logs.

    • We would like certain Axim engineers to be able to have SSH access to the boxes.

  3. Easier installation of Tutor plugins

    • Installing or modifying Tutor plugins is a very common use-case. One problem right now is that specifying the “Tutor requirements” list in the PR description will wholesale replace the default Tutor requirements, thus leaving the sandbox broken if the user doesn’t know to specify the right base requirements (tutor-contrib-grove, tutor-contrib-s3, etc.)

    • Example…

      • The user of this PR’s sandbox wanted just to install a patched version of Tutor:

        • Code Block
          git+https://github.com/brian-smith-tcril/tutor.git@nightly-node18-patched

      • In order to get the sandbox working, they had to repeatedly edit the requirements list via trial-and-error until they finally got a working box by specifying:

        • Code Block
          git+https://github.com/brian-smith-tcril/tutor.git@nightly-node18-patched
git+https://github.com/overhangio/tutor-mfe.git@nightly
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main
git+https://github.com/hastexo/tutor-contrib-s3.git@main
git+https://github.com/overhangio/tutor-forum.git@nightly

    • Ideas:

      • Make the “Tutor requirements” list act as a list of requirement overrides and additions rather than a wholesale replacement of the default requirements list.

      • Have a consolidated single “tutor-contrib-pr-sandbox” requirement which transitively installs tutor, grove, s3, and anything else that the sandbox needs.

      • As a last resort… make the docs extremely clear and up-to-date regarding which base requirements need to be included.

  4. More examples in the docs

    • Grove configuration is very powerful, but it can be confusing how to interact with the different layers (Grove, Tutor, Open edX) and accomplish various common tasks. Particularly, we need an example of a PR or PRs which:

      • Overrides a Waffle flag

      • Overrides a value in MFE_CONFIG

      • Enables a new custom micro-frontend

      • Points to a fork/branch of an existing micro-frontend

      • Adds a custom Tutor plugin

      • Point to a fork/branch of an existing Tutor plugin

      • Uses site configuration

      • Uses a custom brand

  5. Auto-provisioned data

    • We’d like each instance to be pre-provisioned with:

      • A list of course runs to import, each specified by:

        • an Org, Course, and Run

        • a URL to a tar.gz file

        • By default, this list should include one item:

          • Code Block
            - org: OpenedX
  course: DemoX
  run: DemoCourse
  url: https://github.com/openedx/openedx-test-course/blob/master/dist/test-course.tar.gz

      • A user instructor@openedx.org (PW=instructor) who is an instructor in all courses

      • A user learner@openedx.org (PW=learner) who is enrolled in all courses

      • Note: We do not necessarily need the demo library to be imported.

...