Content Comparison

Adam Stankiewicz

https://github.com/openedx/paragon/issues/3425

Notes

• findDOMNode is used by react-bootstrap’s OverlayTrigger

• We are on Bootstrap 4 and react-bootstrap v1.

• Open edX has not yet decided what to do with Bootstrap v4 → v5 (or move away from Bootstrap)

  • Caveat with the v5 upgrade: with design tokens / CSS variables, we’d need to continue porting some v5 Bootstrap code locally within Paragon.

• Next steps: Bring this discussion to FWG for broader discussion & possibly involve UI/UX WG, too (as needed).

Brian Smith

https://github.com/openedx/frontend-platform/pull/689

• Just want to go through the open comments to see if we can move some of the conversations forward

Adam Stankiewicz

• @edx/brand-edx.org is hardcoded in edx-platform’s package.json.

  • Why? 2U’s build pipeline for edx-platform doesn’t properly handle NPM aliases for @edx/brand (like MFEs); this follow-up work was deferred and never prioritized / ticketed (back in 2020)…

  • edx/edx-themes references brand-edx.org

  • For community/non-2U instances, the installed package is likely a no-op (nothing references it).

• Removing @edx/brand-edx.org from package.json in edx-platform should likely go through DEPR process.

  • Would likely break 2U/edX.org styles, if removed unintentionally.

  • 2U/edX has no plans to further invest in @edx/brand-edx.org as we’ll be starting to migrate to @edx/elm-theme instead.

    • TBD implications for edx/edx-themes, since @edx/elm-theme requires Paragon v23 and there’s no plan to get v23 into legacy edx-platform frontends.

• edx-platform is running Paragon v2; will be difficult / impossible to upgrade to v23.

  • No current plans to get to latest Paragon in edx-platform.

    • Has been attempted, without luck, and deferred several times over the last few years.

  • Instead, we’d love to get all the frontend out of edx-platform is the ideal situation, but not trivial/immediate…

    • XBlocks runtime would also be tricky.