...
Before we ask dev teams to review our PRs, it's advantageous to review tickets internally first. In general, it's nice to tag someone who is familiar with the area of code that your PR touches. It's not necessary though. So, when you open a new PR, do the following:
- If you have a good idea of who to tag through git blame or previous knowledgeit's very obvious that someone should review the code, tag that person
- Otherwise, ask either in standup or in the escalation room of who would be good to review the PRrun this script to figure out whom you should tag: https://gist.github.com/adampalay/7fb189284f3d215369b264f004de11c6
I'd expect folks to tag 1 (max 2) internal reviewers before asking for a pull request from a team.
...
- For ECOM, ask the bug czar (listed in the top of the ECOM room in hipchat), or AwaisQ (Deactivated) or someone else in Lahore
- Note: for small, clear issues, there's no need to tag someone in Lahoreon ECOM — two Escalation thumbs up are ok
- For TNL/Platform, either ask someone in Lahore first (like Usman may know who to tag for TNL), or ask in their HipChat channels.
...