...
Blended team creates a PR with a name matching the following template:
[BD-XX][TNL-XXXX] PR name
. This way a Jira ticket is automatically created in the Blended project.
Example BD PR and its related BLENDED ticket.Once the PR is ready for the Blended team’s review, the author of the PR marks a related
BLENDED
ticket as ready for community review (Workflow → Open edX Community Review
). This adds an
label to the GitHub PR.Status colour Green title open edx community review Usually (see Exceptions below), Blended team first reviews the PR internally. If there are requested changes, then after leaving all comments on the PR, they mark a related
BLENDED
ticket asWaiting on Author
, which adds the
label to the GitHub PR.Status colour Blue title waiting on author The PR's author:
Addresses the comments.
Makes necessary changes to the PR.
Marks a related
BLENDED
ticket as ready for community review.
Go back to point 3.
Once all significant internal requested changes are addressed, a reviewer from the Blended team:
Leaves an approval on the PR.
Example approval.Marks a related
BLENDED
ticket as ready for edX review (Workflow → Review In Progress
). This adds an
label to the GitHub PR.Status colour Green title engineering review
edX team (or blended team core contributor, if one exists) reviews the PR. If there are requested changes, then after leaving all comments on the PR, they mark a related
BLENDED
ticket asChanges Requested
, which adds the
label to the GitHub PR.Status colour Blue title changes requested The PR's author:
Addresses the comments.
Makes necessary changes to the PR.
Marks a related
BLENDED
ticket as ready for edX review.
Go back to point 5.
edX team(or blended team core contributor, if one exists) leaves an approval on the PR and merges it.
If a related ticket exists in edX Jira (example “upstream” ticket), then edX team marks it as
.Status colour Green title Done
...