Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

A new PR should be triaged within a week. During triage, a decision must be made as to whether or not the project is interested the PR, and it mustbe closed within this period if the project does not outright want it. Remember: Learn to say no.

Elaborating on the above: Your job is to look at the PR when it comes in, and make some kind of decision about it. Say what you know as soon as you know it, even if it’s only partial (for example, “This looks like it could be interesting, but we are busy right now. We expect we’ll be able to get back to you about it in two weeks”). Sometimes something that initially looks good may turn out to be something you don’t want; it is OK to initially say “this is interesting to us” just to close the PR later - the PR may end up being wrong for the project, and you may only realize that on deeper review. Remember that partial answers and some amount of uncertainty is always OK. Remember that we are people talking to people, not corporations making promises.

Once triaged, the maintainer team must respond within a week to an author’s updates (new commits/comments/questions that require attention - such as requests for re-review).

...