If you choose one of these OSPRs, assign it to yourself and add the label cc-reviewer to it.
Note: You may not be able to update the Jira tickets yourself right now. We are working with edX IT to address this access issue. In the meantime, contact @Natalia Berdnikov (Deactivated) to update the ticket for you.
If there is no available or appropriate OSPR in the ”CC review please” filter, then you may search for another one on the board as follows.
You can pick the oldest (brown and red in this JIRA board), or what is most relevant to current projects, or use another appropriate strategy.
If you have a desire to adopt a ticket assigned to someone else in Jira, you may reach out to the assignee and check if they are ok with you reviewing for them.
Review-only (not Merge):
If you see a pending OSPR for a repository that you do not have merge access, you are welcome to add your review on that PR. That may help expedite the review process.
Once your review is complete, either:
Option A: tag @Natalia Berdnikov (Deactivated) on the PR and she’ll find someone else to merge.
Option B: tag @core-contributor-committers in slack and see if another Committer is able to merge for you.
Do not merge “Community Manager Review”
If you are reviewing an OSPR that has a yellow “Community Manager Review” label in Github (same Jira status in the ticket), please do not merge. This label indicates that author has not signed the Contributor Agreement with tCRIL, and edX cannot accept their code yet. Once author signs and legal team processes it, Natalia will confirm so by posting in the PR and changing Github label and Jira status. Only after that the PR can be merged.
Please add cc-reviewer label in Github to PRs you want to review, and tag @Natalia Berdnikov (Deactivated).
All PRs that are end-user-facing or introduce a new feature or change functionality, need to be first reviewed by the edX Product Owner of that feature.
You can tag @Marco Morales (Deactivated) on the PR to route the Product review request.
Exception: if PR is fixing an obvious visual issue like a typo or distorted layout, Product doesn’t need to review.
We have high expectations of Committers' ability to review with high code quality in mind, including architecture/design principles and definitions of done (i18n, scalability, etc).
If you have any doubts about accessibility, please tag @Jeff Witt (Deactivated) on the PR.
If you need anything, please tag @Natalia Berdnikov (Deactivated).
If you have any questions/feedback/input on this process, please comment on this wiki or reach out to @Natalia Berdnikov (Deactivated) or @Ned Batchelder (Deactivated) .