2024-02-08 Meeting notes

2024-02-08 Meeting notes

 Date

Feb 8, 2024

 Participants

  • @Feanil Patel

  • @Felipe Montoya

  • @Michelle Philbrick

  • @Kyle McCormick

  • @Sarina Canelake

  • @Tobias Macey

  • @Navin Karkera

  • @Jeremy Ristau

  • @Robert Raposa

  • @Tim Krones

  • @Maksim Sokolskiy

  • @Xavier Antoviaque

  • @Max Frank

 Goals

  •  

 Discussion topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

 

Review TODOs from Last time

@Feanil Patel

 

Ubuntu Upgrade

@Tobias Macey

MIT already running using Debian Buster instead of Ubuntu and using standard python Docker Images

  • Reduces usage of other infra like the deadsnakes PPA.

  • Using the external codejail service and building that against the Ubuntu container.

    • Using a sudoers profile inside the code jail service image.



Node 18 → 20 Upgrade

@Feanil Patel

Looks like we’ll have to accelerate this upgrade to keep things functional. @Adolfo Brandes can you provide some context here?

Context:

  • The upgrade from Node 16 to 18 took a long time, and a lot of coordination. We still have time until Node 18 is EOL (April 2025), but some packages have started to drop support for it already, leading to complications when upgrading related dependencies.

  • Renovate has already started to open 18 → 20 upgrade PRs.

  • To get in front of it, we should elect somebody to start the discovery and coordination work, and set a tentative target: Sumac.

  • Tutor only supports one version of Node in production for MFEs

    • Can we change something in the tutor plugin to bring up a second container for some of the MFEs?

      • @Régis B. people are concerned that a PR to run 2 images would be to clunky to be accepted by the tutor team. Do you have thoughts on how we could incrementally upgrade MFEs without having to do a big bang upgrade of all of MFEs.

      • We’re going to have more MFEs in the future and doing a big bang upgrade can be more costly.

      • Note: In the future we will have the same problem with Piral so we may be stuck with this.

 

Moving NPM workspaces

@Adolfo Brandes

Turns out it’s a pretty manual process. @Brian Smith and now @Yagnesh Nayi have been contributing PRs, but as usual, the more contributors, the merrier!

Main ticket (see referenced issues towards the bottom of the feed): https://github.com/openedx/axim-engineering/issues/23

 

Maintenance burden of org-specific code

@Adolfo Brandes

In going through the above (in particular, when upgrading frontend-app-course-authoring dependencies), we found that the Video Upload feature is not realistically usable by the community. Not only that, it’s not feasible to run it locally for the purpose of, for example, fixing unit tests. We proposed that in such situations, the unit tests be disabled / made non-blocking as a workaround, and long-term, the feature should be pluggified, deprecated, or put in the docs and other work to make it usable by the community.

 

  • We’re aware that we don’t have a single plugin API that we’re going with yet.

  • Can the tests be run elsewhere?

    • How do we run the tests sometimes?

      • This is in Jest, there is some capability for optionally running tests.

  • How can 2U know that 2U specific tests were disabled?

    •  

 

Ruby Upgrade in Comment Service

@Maksim Sokolskiy

What’s the plan with the ruby upgrade?

  • Feanil will prioritize finding a maintainer for this so we can get the Ruby upgrade going.

  •  

 

Central vs Distributed Tasks for Upgrades

 

Who will be in charge of the centralized tasks for upgrades?

  • This group

  • We’ll need help with both the creation of tasks and driving them forward with maintainers

  • Feanil will make board

  • Product roadmap will also have line items for main upgrade epics.

  • Difference between transparency and visibility

    • A board is useful, but comms is still important.

    • Ristau would be happy to help bolster some of the communications and visibilty steps moving forward.

Previous Action Items

 Action items

@Feanil Patel Add a link to the meeting notes to the calendar event.
@Felipe Montoya to connect Feanil with edunext contact who can help maintain ecommerce for now.
@Felipe Montoya to email Feanil a list of repos that edunext is interested in.
@Adolfo Brandes ticket up enabling node 20 tests on all existing released MFEs and post a call to action in the forums.
@Robert Raposa to come back with any process that could help us easily find the disabled tests, specifically with Jest.
@Feanil Patel to create a maintance project board to track all outstanding maintenance work.
@Jeremy Ristau to review existing 2U upgrade processes and comms and update/hand-off to the community.
Anyone can provide feedback to Jeremy via Slack to help improve the process.
@Feanil Patel put up cs-comment-service for ownership and be clear about the upgrade that needs to happen.

 Decisions

 


edx-platform Maintenance Meeting Notes

 Participants

  • @Feanil Patel

  • @Kyle McCormick

  • @Tobias Macey

  • @Jeremy Ristau

  • @Robert Raposa

Discussion Topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

 

Historic edx-platform maintenance state

@Kyle McCormick

We had a central team that would route to experts within 2U. We think that was a good system but we would want to build that with CCs instead of a 2U internal ownership delegation.

  • Michelle was historically doing the routing within edx-platform to 2U.

  • More recently the BOM team tried to take over and that was badly timed.

  • Be mindful about the difference between the alerting setup within 2U which will remain internal and the routing for PR reviews which will become public.

  • Should we be switching to CODEOWNERS instead?

    • CODEOWNERS is not super visible and does not get info to the owners quickly.

    • CODEOWNERS currently auto assigns PRs

 

Impending Redwood Upgrades

 

  • More important than getting the full ownership mapping.

  • For now focus on the upgrades we need for Redwood.

    • Python 3.8->3.10/11/12

    • Mongo 4->6

  • Feanil will work on making tickets for all edx-platform python packages

  • Who will make the PRs?

    • Arbi-BOM used tools to create issues

    • We think they have tooling to update the matrix

  •  

 

3.11 or 3.12?

 

  • If some repos are already running 3.11 let’s aim for 3.11 otherwise let’s get to 3.12.

 

where will the issues go?

 

Feanil will make it

Give him a search query and he’ll ge them on there

 Action items

@Jeremy Ristau to make sure that the internal audit of ownership at 2U will end with an update to CODEOWNERS file to make that mapping public.
@Feanil Patel Ticket running 3.12 testing on all python repos in the openedx org that are in the release with a priority for edx-platform.
@Robert Raposa @Jeremy Ristau will reach out to Arbi-BOM to make the github matrix change PRs for exsting python repos. Also, find out what Python upgrade state is?
@Kyle McCormick Will look into Python 3.9+ dependency on libsass

Decisions

  1. There should be a public routing system/table for routing PRs within edx-platform
  2. We’ll start by putting the mapping into the CODEOWNERS file.

 

Transcript and Recording