Hackathon XIX - Broken Windows

Overview

This page will be the location where we coordinate who is working on what warnings and such.

Join us in the "Hackathon XIX - Broken Windows" Hipchat room.

The epic for all the post-Django 1.11 upgrade work is here:

PLAT-1717 - Getting issue details... STATUS

But it can be just as illuminating to look at the output of a test run. Here is a single example found from a random edx-platform PR with successfully-passed Python tests:

https://test-jenkins.testeng.edx.org/job/edx-platform-test-subset/984654/artifact/lms-tests.6.log


In Progress:

TicketPersonStatus
PLAT-1396 - Getting issue details... STATUS Eric Fischer (Deactivated)No action needed, we don't use makemigrations --exit in edx-platform
PLAT-1397 - Getting issue details... STATUS

https://github.com/edx/edx-platform/pull/18313 has merged

PLAT-1398 - Getting issue details... STATUS Eric Fischer (Deactivated)No action needed, we don't use "virtual_fields" anywhere in edx-platform
PLAT-1399 - Getting issue details... STATUS Eric Fischer (Deactivated)Not applicable to edx-platform
PLAT-1401 - Getting issue details... STATUS Eric Fischer (Deactivated)Not applicable to edx-platform
PLAT-1402 - Getting issue details... STATUS Eric Fischer (Deactivated)Partially fixed, blocked on external changes.  Returned to backlog with notes on partial completion status
PLAT-1524 - Getting issue details... STATUS Tyler Hallada (Deactivated)

Done - https://github.com/edx/edx-platform/pull/18316

This one which happens upon every server restart:

edx.devstack.lms     | 2018-06-05 13:56:00,092 WARNING 241 [py.warnings] fields.py:455 - 
/edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/edx_sga/sga.py:85: 
FailingEnforceTypeWarning: The value u'Staff Graded 
Assignment' could not be enforced (TypeError: Value 
stored in a String must be None or a string, found 
<class 'django.utils.functional.__proxy__'>)

TE-2584 - Getting issue details... STATUS

Julia Eskew (Deactivated)

Working on it... will be modifying the XBlock repo to fix, allowing i18n strings for defaults in XBlock String fields, if all goes well.

PLAT-1835 - Getting issue details... STATUS Mike Youngstrom (Deactivated)Done - https://github.com/edx/edx-platform/pull/18314 has merged
PLAT-1384 - Getting issue details... STATUS Brian Mesick (Deactivated)Done - no issues found.
PLAT-1700 - Getting issue details... STATUS Jeremy BowmanDone - minor test fix submitted, keeping the ticket open until that's merged
PLAT-1880 - Getting issue details... STATUS Brian Mesick (Deactivated)Done
PLAT-1454 - Getting issue details... STATUS Mike Youngstrom (Deactivated)No action needed
PLAT-1425 - Getting issue details... STATUS Brian Mesick (Deactivated)Done
PLAT-1746 - Getting issue details... STATUS Tyler Hallada (Deactivated)

Done - https://github.com/edx/edx-platform/pull/18324

This warning:

2018-06-06 09:00:32,220 WARNING 2477 [py.warnings] fields.py:455
 - /edx/app/edxapp/venvs/edxapp/local/lib/python2.7/site-packages/poll/poll.py:607: 
FailingEnforceTypeWarning: The value (('Y', 'Yes'), 
('N', 'No'), ('M', 'Maybe')) could not be enforced 
(TypeError: Value stored in a List must be None or a list, found <type 'tuple'>)
  scope=Scope.settings, help=_("Answer choices for this Survey")

TE-2583 - Getting issue details... STATUS

Done -

https://github.com/open-craft/xblock-poll/pull/42

https://github.com/edx/edx-platform/pull/18347

PLAT-1828 - Getting issue details... STATUS Mike Youngstrom (Deactivated)Done - https://github.com/edx/edx-platform/pull/18328 has merged
PLAT-1452 - Getting issue details... STATUS Brian Mesick (Deactivated)Done https://github.com/edx/edx-platform/pull/18329
PLAT-1528 - Getting issue details... STATUS Tyler Hallada (Deactivated)Not applicable to edx-platform (found no instances of ".rel")
PLAT-1849 - Getting issue details... STATUS Tyler Hallada (Deactivated)WIP - Not surprising, but this is turning out to be a big effort and I might abandon it https://github.com/edx/edx-platform/pull/18333
PLAT-1565 - Getting issue details... STATUS Brian Mesick (Deactivated)Mostly done in previous work, just deleting the monkey patch file itself. In code review https://github.com/edx/edx-platform/pull/18332
PLAT-1435 - Getting issue details... STATUS Mike Youngstrom (Deactivated)No action needed
PLAT-1829 - Getting issue details... STATUS Mike Youngstrom (Deactivated)This was taken care of in PLAT-1835


https://openedx.atlassian.net/browse/PLAT-1528