2024-04-25 Meeting notes

 Date

Apr 25, 2024

 Participants

  • @Feanil Patel

  • @Robert Raposa

  • @Jeremy Ristau

  • @Kyle McCormick

  • everybody else add yourself!

Previous TODOs

 Discussion topics

Item

Presenter

Notes

Item

Presenter

Notes

Start Recording

 

edx-platform Python requirements update

@Kyle McCormick

2U monitoring project

@Robert Raposa

2U is busy with a monitoring switchover until end of May

  • Product review vs arch review of this

    • robert: people out there use NR, so it is bundled with the platform, so it seems reasonable that DD would be available as well

    • Currently the two will be done together where it makes sense and the Product WG will tag eng folks where it makes sense.

    • (Lot of other discussion I didn’t capture, see recording)

Node 18 upgrade work

 

  • Need to have a retro on this work.

  • Node 20 will need to land in Sumac

Settings Files

 

  • ran out of time

Python 3.11 upgrade and translations

 

  • edx-platform is getting close

    • enmerkar-underscore blocked on an external library that hasn’t gotten updates in 8 years.

      • Will need to fork (and fork its dependency too) unless we can confirm that we’re not using it.

      • If you can help with figuring this out please stick around after the call

  • PRs open for course-discovery and credentials, if you have context please take a look and see if you can help nudge them forward

 

 

  • Next week: maintenance priorities for Sumac

    • Python 3.12, React, et al

    • Let us know of other priorities you’re aware of!

    • Adolfo: OEP-65 (composable MFEs) will impact micro-frontends

    • Feanil: Landing automated upgrade PRs in a timley manner

    •  

 

 

 

 

 

 

 Action items

@Robert Raposa Talk to Tim McCormack about extra_requires
@Feanil Patel Schedule retro for Node upgrade

 Decisions

Recording and Transcript

Recording: https://drive.google.com/file/d/1V-lLlExlHy3-Nvz2zOrbVuffv1uN-4IA/view?usp=sharing

edx-platform Maintenance  Sub-Group (2024-04-25 09:01 GMT-4) - Transcript

Attendees

Adolfo Brandes, Awais Qureshi, Feanil Patel, Feanil Patel's Presentation, Felipe Montoya, Jeremy Ristau, Kyle McCormick, Maksim Sokolskiy, Maria Grimaldi, Piotr Surowiec, Robert Raposa, Sarina Canelake, Tim Krones

Transcript

This editable transcript was computer generated and might contain errors. People can also change the text after it was created.

00:25:00

Feanil Patel: Tendencies and cleaning up some of these things that seem tedious but then impact the long-term health and sort of viability of the code base. We're going to be sort of spending a little bit more time on I think than we had historically.

Jeremy Ristau: Yeah, and I think it would be important for me and potentially. probably not other people, but maybe to say Can we know…

Feanil Patel: Okay.

Jeremy Ristau: what things you are targeting for the next release to make it smaller?

Feanil Patel: Yeah.

Jeremy Ristau: Because if each one of those requires four weeks of reactionary or preemptive work on our part, we can't fit that many into a window of time and…

Feanil Patel: No, absolutely.

Jeremy Ristau: and I think that's like is this number one or is this number 12 would be nice?

Feanil Patel: I can get you that let's yeah.

Jeremy Ristau: Okay,…

Robert Raposa: Yeah.

Feanil Patel: Yeah, I can get you that list.

Jeremy Ristau: so rich.

Feanil Patel: The plan is for so as in the maintenance spreadsheet,…

Jeremy Ristau: Yeah.

Feanil Patel: there's that checkbox to deprecate. Column, those are all things that I will be targeting one of my goals and…

Jeremy Ristau: Yeah.

Feanil Patel: the post python upgrade realm is to prioritize that and add deers for all of those and then these are the first two I'm going to be working on. I'm very flexible between here and soon act when they fully land if people need time to adjust to them, but these two are the things that we need to land first.

Feanil Patel: And then these will be the next ones in the next ones and hopefully as I get those in there and as we start becoming more intentional we can even start setting some of those milestones for further out releases. Then just the current one,…

Jeremy Ristau: Yeah.

Feanil Patel: but I think for now these are the ones I want to land by six months from now.

Jeremy Ristau: And Beyond post python world, is that post post 311 or post 312?

Feanil Patel: I think post 311 I want to. Shaped focus a little bit and work on some of these other things. There's a question of I really want to get three 12 to edx platform by CMAC. I think it'll be a pretty small lift, but I might not pick that up till Post open edx conference. So Late July early, August and sort of At that point a lot of the libraries already have support for both. So it'll be just a matter of collecting what's left and distributing that work amongst maintenance and those who can help. so

Jeremy Ristau: Okay, cool. Thank you.

Robert Raposa: Yeah, we did have some Depot process improvements that hopefully will make the depart board a much more clear list of things you are. making it more clear to me though that As you know, we're in the time of a particular release. right now and so anything that gets planned now for this release and is a new Dipper ticket that drops in the Consider is…

00:30:00

Feanil Patel: yeah.

Robert Raposa: if we don't actually say we're going to give it a whole nother release then it gives less and less time for each of these things. So we should figure that separately.

Feanil Patel: right

Kyle McCormick: I think at this point It should be another release. I'm just gonna off the cuff say that if people are trying to slam in Diapers at this point probably better let it sit. until after the Redwood cut

Feanil Patel: It wait two weeks and then merge it and then the effect is very similar from the community perspective and you give them a lot more time.

Robert Raposa: Yeah.

Robert Raposa: and then there Welcome everyone.

Feanil Patel: Cool, welcome everybody knows.

Robert Raposa: I had one other thought maybe for a future conversation but Sort of the node. upgrade work RCA or stuff and what's the best way we can all help each other right, the great part of it is we know it'll be working for the community when the community uses it right so…

Feanil Patel: Yeah.

Robert Raposa: but is there some other process improvements to

Feanil Patel: Yeah.

Robert Raposa: take or not to get to that.

Feanil Patel: I mean I have on my list of retrospective for that work because I have at least two things that I noted during that release that were fully untested before going to Stage that feel like they should have much more thoughtful testing proctoring being one of them. I'm surprised that We didn't find proctoring was broken until it went to staging slash production for you guys But it's also proctoring is not necessarily a core feature.

Robert Raposa: Yep.

Feanil Patel: So that's one where I'm going to need to partner with you guys to figure out what the strategy needs to be for that Robert.

Robert Raposa: right

Feanil Patel: If you could tell me who the right people from to you are to participate in that retro. I want to make sure that they can attend because

Feanil Patel: As the sort of can the bleeding edge consumers of this work. I want to make sure that we have them in the room, but I think a community retro on the Note 18 upgrade to sort of figure out…

Sarina Canelake: Hello.

Feanil Patel: how we can do better with the new 20 upgrade which I think is slated for sumac Right now,…

Robert Raposa: Yeah.

Feanil Patel: all right needs to be slated for sumac because it must go out before sumac is pregnant from wrong on that Adolfo but Yes.

Adolfo Brandes: That's correct. It has to be done before sub.

Robert Raposa: And then yeah, I think so. I think Diana could probably get you a list of anyone that we would invite to nrca related to that. That's probably people who could get invited to it and proctoring is a good example, but there's the general idea of how do we deal with? plugins even if it was a plugin that will affect people when they actually get to it,…

Feanil Patel: Yes.

Robert Raposa: but how can they know about that test it or get in? some sort of? related tests if necessary

Feanil Patel: Yeah, and I definitely thoughts on that.

Robert Raposa: 

Feanil Patel: I think a lot of these interfaces are implicit and not tested and that's part of what we want to fix right? So

Robert Raposa: that's all Cool. Thank you.

Feanil Patel: and we'll come back to settings files next time.

Feanil Patel: Everybody Welcome to the maintenance working group.

Feanil Patel: Real quick. Yeah, I'll just grab the Wiki page one more time, so everybody's got it.

Feanil Patel: Wanted to cover the python 311 upgrade and where we're at on that which is mostly good news. I think and then start figuring out what else we need to land before Redwood cut if anything in terms of Maintenance next week, I will going to collect a list of which maintenance priorities for sumac because that is the next conversation. We need to be having and what maintenance we're going to be doing in sumac because a market in the last five minutes, we've already mentioned python 312 upgrade the node 20 upgrade and I think there's a react upgrade that needs to land perhaps so I want to do an assessment there. and get people's thoughts on how to prioritize because I think that we talked about previously which was

00:35:00

Feanil Patel: where the same resources need to be used for multiple upgrades making it clear what the highest priority upgrade is. So that people know where to focus energy if they have limited energy, which I think most everybody here has limited energy. Because of other work that they're doing so if you have other maintenance priorities that you think will need to be completed before sumac. Please put them in here or let us know slack me put it in the WG maintenance Channel. However, you want to anything that's short of yelling it at your own computer, but not actually telling a human is helpful.

Sarina Canelake: Okay.

Adolfo Brandes: Formalize this. However you think is best but The web 65 which deals with composable mfps, and module Federation will have consequences regarding front-end maintenance.

Feanil Patel: Okay.

Adolfo Brandes: but details are still being ironed out, but we want to come out of the implementation of that in a much better place to

Adolfo Brandes: to make react upgrades and let dependency upgrades across the board. So it's sort of a heads up. Yeah.

Feanil Patel: That sounds good. I know one of the things that accent improvements did recently was land a bunch more renovate updates because there are a bunch of front-end repos that didn't have renovate config. And so we're even getting some of those package update notifications slash PRS. But I think there's also this known issue of renovating and dependabot upgrades that. Are pull requests that are just running in the background chewing up CPU and rebasing but not actually getting landed. So I think there's a question of getting.

Adolfo Brandes: Yeah.

Feanil Patel: I think this will one of the other things that needs to happen between here and sumac has more maintenance need to be found for all of these packages so that

Feanil Patel: We can have individuals who are responsible for them. So that's the other big Focus. I think once we can get red without the door is let's go look at what's left on the list of things that are not maintained and Get maintenance for the high priority items.

Feanil Patel: Okay.

Feanil Patel: Cool, so real quick on the python 311 upgrade I think. Then she was in course Discovery both have pull requests out, but I don't know if there are reviews happening of those. So if people have space and have knowledge of those to repositories, please take a look at them edx platform is I think down to three dependent packages that need to add Python 3 12 3 11 support one of code review two of which are in code review and one of which is this unmarked our underscore package, which might not be used. So if you know anything about translations in Python code in edx platform and want to stick around after this call.

Feanil Patel: Please do. I think this package is not being used but I need to confirm that and if that's the case, then we don't have to Fork right now. This repository is a fork in the open edx org. And in order to fix it. We will have the 4K second repository into the org and fix that because the dependency of this package is what has the Python 3 11 and compatibility so that is possible and totally doable and we can do it quickly, but I would love to not have a fork of a dependency of our Fork of Mars. Just because I don't want to have to explain it's too embarrassing honestly.

Kyle McCormick: Middle of the other repo websites course discovery that you said at PR is open.

Feanil Patel: A credentials also has a PR open. But I think it needs more work. It's a draft PR. There's a message on it that I didn't understand which was somebody said we can't do this until There's a blocking tutor change. But as far as I know. the application Repository should always be updated before the tutor update.

Adolfo Brandes: That which we'll know we're talking about again. Sorry.

Feanil Patel: credentials credentials

Feanil Patel: I think we should be testing in both versions before. So that was confusing to me. I raised a question, but I don't think I've gotten a response on that one yet.

Adolfo Brandes: Yeah who are tutors Downstream? So

00:40:00

Feanil Patel: also a reminder. If you have expanded your rights and are now the maintainer of a thing. Please make sure and update catalog info files in those repos. I know a bunch of you have done that already. But if you have friends who are becoming maintenance of things, please remind them to do that. I know I round up the latest list of Maintenance and make sure that they all have done that but honestly, I've not done anything other than work on python 311 upgrades for the last little while so Felipe

Felipe Montoya: Should we use the block user colon? And then the username or something with groups?

Feanil Patel: Yeah, yeah users are fine. If it's only one person if it's multiple people and we need to make a group you can file an axon request ticket to make a group. But a user is totally fine. I think in a lot of these cases.

Felipe Montoya: All right. I'll still need to open an axiom ticket To get the CC permissions and then I can do the fork and all. the

Feanil Patel: awesome Yeah, perfect. That sounds great. Yeah, please file those go to a guy that looks a lot like me right now. Happy to accelerate them.

Feanil Patel: All right. Yeah, the other major update as you we talked about the note 18 upgrade did go out. I think as far as I know it is still currently out now overnight. So the last couple of issues I think got resolved yesterday. Thank you to Brian Smith and Diana Wong and all the other people who stepped in to help with that.

Feanil Patel: But I think that is in hopefully good shape. Which is great. We're meant to get that out. I think before Quince cut. So I'm glad we'll be able to get it up for Redwood is cut.

Feanil Patel: And yeah, we'll be working on the Note One the upgrade after that good.

Adolfo Brandes: I mentioned this yesterday out of accent standard, but if anybody needs a reason to explain why mfps Were a good architectural Direction? The troubles we found with the note 18 upgrade are a very good example. right of why so yeah.

Feanil Patel: Yeah. Yeah, I think we just need to being in both worlds is kind of the worst of all situations and I think we're going to keep moving

Adolfo Brandes: exactly I just say that since there are so many people from different orgs here and some orgs haven't been convinced…

Feanil Patel: Yeah. Yeah.

Adolfo Brandes: if you Just look at how easy the note 18 upgrades were in mfe's and how hard it was platform. As an example. I'm not going to get into the details of why it's just easier.

Feanil Patel: For any other things people want to cover today? Thanks very short meeting today. The big thing is please think about maintenance priorities for sumac and let's get those written down and communicated.

Feanil Patel: I think we're good then.

Feanil Patel: Thanks. Thanks everybody.

Kyle McCormick: If no we can just stick around for a…

Adolfo Brandes: Thank you.

Feanil Patel: Yeah, I'll Stick Around Kyle.

Kyle McCormick: Yeah, anybody else interested in kojo can stick around?

Sarina Canelake: I thought it was there a question about translations.

Kyle McCormick: Yeah.

Feanil Patel: Yeah, if you have translations knowledge and you want to stick around please do.

Sarina Canelake: Have Arcane and ancient translations knowledge, but I will hear your question.

Feanil Patel: And that might be what we need. I'm gonna stop the recording as I'm gonna say just meeting his concluded and this is now just technical pairing stuff

Adolfo Brandes: later

Robert Raposa: other question the settings topic, did we ever get to

Meeting ended after 00:44:16 👋