Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

This issue can't be edited

Because it belongs to an archived project. Jira admins can restore projects from the archive.

Comprehensive theme templates not working on wiki

Description

Comprehensive theme template overrides do not work on pages using the main_django.html template (for example the wiki).

I suspect the bug was introduced while migrating to django 1.8.
The line in https://github.com/edx/edx-platform/blob/6cb62f2697bcca1380854e139857678b2ddc35e0/openedx/core/djangoapps/theming/core.py#L34 is probably not correct - I believe TEMPLATE_DIRS should be replaced with settings.DEFAULT_TEMPLATE_ENGINE['DIRS'], although I tried doing that and it didn't seem to have any effect, so there must be something else going on.

Steps to Reproduce

1. Set COMPREHENSIVE_THEME_DIR to /edx/app/edxapp/edx-platform/themes/red-theme in your devstack. 2. Restart LMS. 3. You will see the default logo in color and the footer will be red. Compare the content of the header and the footer on the wiki with content on the other pages (for example "Course Info"). 4. Note that the wiki does not use overriden header.html and footer.html themplates from the themes/red-theme/lms/templates folder, although custom logo and and custom CSS which paints the footer red both work correctly.

Attachments

2

Confluence content

mentioned on

Lucidchart Diagrams

Activity

Matjaz Gregoric 
October 26, 2016 at 5:16 PM

It works fine on Eucalyptus. This can be closed

Braden MacDonald 
October 26, 2016 at 4:58 PM

What's the status of this - was anything done since your PR was reverted, or is this still unsupported?

Matjaz Gregoric 
January 25, 2016 at 7:59 AM

Matjaz Gregoric 
January 7, 2016 at 8:36 AM

I added some comments about what I discovered in https://openedx.atlassian.net/browse/OPEN-982

Matjaz Gregoric 
January 7, 2016 at 8:09 AM

Actually, this does seem related to Django 1.8 upgrade. It used to be possible to override the main_django.html template from a stanford-based theme (as in https://github.com/IONISx/edx-theme/blob/master/templates/main_django.html), but that doesn't work anymore.

Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Parent

Priority

Zendesk Support

Created January 4, 2016 at 8:43 AM
Updated September 26, 2017 at 7:48 PM