Versions Compared

Old Version 3

changes.mady.by.user Gabriel Weinberg

Saved on

compared with

New Version Current

changes.mady.by.user Gabriel Weinberg

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Goals

  • Align on how to proceed with merged code that still needs design review

...

Time

Item

Presenter

Notes

Ben Warzeski (Deactivated)

  • https://github.com/edx/paragon/pull/808
    What to do with the CardSelect component that did not go through our design or review process?

    • Problems: inflexible

    • Initial design specs don’t match the merged code

    • Fix forward or revert?

      • Revert: +4

      • Fix forward:

    • Semantics

    • What is our community dev process?

    • Design revisit specs and use cases

    • Interaction specs, clickable inside card

    • Process: reviewer group? checklist? pull request template? Should be working from a spec and proposal. Design system itself can act as a gatekeeper for consistency. Will design or tech debt be paid back within a reasonable time? Front end working group?




Ben Warzeski (Deactivated)


Should the select menu location move its location in the docsite?

Action items

Decisions

  • Revert merge of code
  • Component rebuild for better flexibility
  • Design spec first, then code