We intend to modify the search functionality in the new MFE such that:
...
Figma mockups: https://www.figma.com/file/LVFnO9oRHYiamoicZuXDAC/Discussion-page?node-id=1604%3A1338
[Question]: Should the search be dynamic (results appear as the user type)?
No! Search functionality
...
will be triggered when user clicks the magnifying glass icon in search box or presses Return key when in the search box and at least 1 character has been typed in the box.
Reason: No need for unnecessary API calls. Topics are filtered on frontend so it's easier there. But content and users are filtered on the backend.
[Question]: Do we want to put a character limit on search for content, topics or posts?
Probably yes.
[Question]: Do we want to paginate search results for users?
Yes. Just to be on safe side incase a user searches single letter and lots of users get returned. Limit of 10 should be sufficient.
...
Tab selected | Show Search info bar | Show Filter/ sort bar | Placeholder text | Search box logic |
---|---|---|---|---|
My posts | Yes | Yes (with same options as without search, reset to default sort upon search) | Search all posts | Same as in legacy. Searches for provided string in post title, content, response and comments. |
All posts | Yes | Yes (with same options as without search, reset to default sort upon search) | Search all posts | Same as in legacy. Searches for provided string in post title, content, response and comments. |
Topics | Yes | No | Search topics | Same as legacy. Filters topics based on provided string on the frontend. |
Learners | Yes | Yes (with same options as without search, reset to default sort upon search) | Search all learners | Same as legacy. Filters users based on provided string. It will still search users when a particular user is selected. |
...
Action | Mockup |
---|---|
Default view of | |
| |
| |
| |
In light of currently available APIs, is this sorting and filtering being done on frontend or in cs_comment service? | Legacy view: |
Warping Wrapping long search strings. |
Searching topics
The following behaviour behavior is illustrated for when Topics
tab is selected.
Actions | Mockup |
---|---|
| |
| |
After rollout of 1.7, will we search 3rd level of hierarchy? How will those results be rendered? This is an open question that Jonathan and I are working on. As of now, we haven’t rolled out 1.7 yet. So the objective is to replicate exactly what is being done in legacy experience. In legacy experience, as per Kshitij, all topics are being loaded on the frontend and searched there. |