Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Time

Item

Presenter

Notes

Chip design & a11y discrepancies

Adam Stankiewicz (on behalf of Julian Gil)

a11y

we can see that there was a change in the `Chip` component, initially due to accessibility this component used to be a button, now it is a div.

v20.11.0+ refactored Chip to match the chip design in the Multiselect component based on a decision that made in a PWG meeting (meeting notes).

In doing so, Chip is now always a div, but has an interactive trailing icon to dismiss it. The refactor did not consider other use cases of non-dismissable chips that still interactive Chip (e.g., using Chip as if they are tabs).

design

before

after

Notes:

  • The Chip design now matches the Figma spec for the Chip designed for Multiselect based on a decision made in PWG.

  • The Chip component in Figma is not updated to reflect the decision made in PWG.

  • Unclear path forward in terms of what the Chip styles should be at this point.

PWG feedback:

1 min

Docsite navigation

Gabriel Weinberg

Looking for a quick reminder on where we left off with this project.

  • Blocked on code review

    • Feedback is not blocking

Design tokens

Brian Smith

What can Brian/trcil do to support this project?

✅ Action items

  •  

⤴ Decisions

...