2023-06-22 Frontend Working Group Meeting Notes

React 17 vs React Router upgrade plan

Muhammad Abdullah Waheed Khan

• Any reason to do one before the other?

  • react-router has some possible a11y improvements

  • …but React 17 will be easier

• React 17 blockers?

  • Hotjar might be a problem

    • FED-BOM will take care of it

  • Enzyme is only a problem on 18

• https://blog.logrocket.com/migrating-react-router-v6-guide/

Handling babel-plugin-react-intl deprecation

Muhammad Abdullah Waheed Khan

https://github.com/openedx/wg-frontend/issues/120

10 min

Frontend dependency upgrade policy

Jeremy Bowman (Deactivated)

• For Python, we have https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0018-bp-python-dependencies.html

• We’ve decided to use Renovate, but haven’t reviewed the config in a while

• Many teams aren’t on top of NPM package upgrades, even when Renovate is enabled

• Should we write an OEP or ADR stating and justifying our dependency upgrade policy?

  • Improve the process of reviewing and merging the Renovate PRs: this should be done regularly

  • First: decide what the process is going to be

  • Second: extend maintainers’ responsibility to include it

• There may need to be accompanying training to socialize the change

Training

We need more frontend-specific documentation and training.

Currently we have things like:

• Frontend Handbook

• https://open-edx-proposals.readthedocs.io/en/latest/best-practices/oep-0011-bp-FED-technology.html

Set up a sub-group to discuss generating content?

• Before a separate group, do we have volunteers to help create content?

  • Pedro (Piral) 🖐

  • Ben and Jesper (Patterns/Standards)🖐

  • Adolfo and Brian Smith (General/Coordination)🖐

    • (Axim might be able to fund some of this work)

10 min

github config for new @openedx repos

Ben Warzeski (Deactivated)

referenced repo: @openedx/react-unit-test-utils

Issue: new @openedx repo configured with permissions that prevents semantic release from generating releases on the repo.

Not expecting to resolve here. mostly an inform

@edx vs @openedx npm packages

• “@edx” is currently whitelisted for building, which is why even new packages use it

• A low-hanging fruit would be to whitelist “@openedx” as well, and have new packages use that

• Eventually we’re going to want to rename “@edx” to “@openedx”

  • We’re already hearing reports of this causing confusion among developers

Enzyme deprecation/migration howto

• https://github.com/openedx/public-engineering/issues/195

• We should propose an ADR, and use the PR as a basis for conversation on how to do it

Integration vs Unit tests

This is a long conversation, but we should definitely have it, at some point; possibly as a follow-up to the Enzyme deprecation.