[DRAFT] Guideline: When does a PR need Product Review?

WORKING DRAFT

 

What is the purpose of this document?

The purpose of this document is to define clear guidelines for when a PR should be passed along to a Product Manager for review.

 

Who is this document for?

It’s intended audience is:

  • Project Managers who triage OSPRs

  • Engineering Managers who review OSPRS

  • Repo Owners who review OSPRs

 

When does a PR need Product Review?

User Experience Change

The general rule here is that a PR requires product review if the PR results in a change, big or small, to the end-user experience, particularly for learners, course authors, course teams, or course/instance administrators.

Some general guiding questions:

  • Does this change or impact a feature that a learner would interact with?

  • Does this change or impact part of the authoring flow?

  • Does this change or impact the experience of configuring content or a course run?

  • Does the change or impact reporting?

  • Is this change related to Studio or Content Libraries?

  • Is this change related to the LMS?

Divergent Notions

In order to avoid rapid flailing, it’s prudent for product managers to get involved if there are more than one PR attempting to adjust the repo in divergent ways.