Code Review Plan

Pending & In-Progress PRs

 

 

 

 

Pending

edX Code Review not started yet. No blockers, the PR is waiting for its turn in queue or is a WIP.

In Review

Actively under edX Code Review and feedback phase.

Blocked

edX Code Review on hold. More details on PR.

Approved

edX Code Review Done. PR got 2 from edX team but it is not yet merged.

WIP

PR is a work in progress, but is included here so it can get early feedback.

Opencraft / infinity

Status to further explain out the codes above with regards to the team weather its open-craft or infinity.

 

No.

Status

Reason (if any)

Milestone

PR#

Description

Reviewer

1

in review

ADR for information only

v1.7

https://github.com/openedx/edx-platform/pull/30075

ADR about topic structures

 

 

Completed

133

No.

Milestone

PR#

Description

No.

Milestone

PR#

Description

1

v1.3

https://github.com/edx/edx-platform/pull/26965

 

2

v1.3

xblock-lti-consumer#159 refactor: Move CourseEditLTIFieldsEnabledFlag to lti_consumer [BD-38] [TNL-8104]

v1.3

Moves the CourseEditLTIFieldsEnabledFlag from edx-platform where it’s only available to CMS applications, to xblock-lti-provider where it’s available to both Studio and LMS.

3

v1.5

edx-platform#27542 feat: Course Apps API [BD-38] [TNL-8103] [BB-2716]

Implementation of Course Apps API

4

v1.5

edx-platform#27193 docs: ADR for new course apps API [BD-38] [TNL-8002] [BB-3964]

ADR that introduces a new type of plugin called a “course app” which will show up in the new pages and resources API.

5

v1.3

edx-platform#27529 refactor: Move CourseEditLTIFieldsEnabledFlag to xblock-lti-consumer [BD-38] [TNL-8104]

v1.3

The other half of the above PR. It is dependent on the above PR since the version bump in this PR will be for the above.

6

v1.5

https://github.com/edx/frontend-app-course-authoring/pull/63

v1.5

Implements the individual components of the pages and resources view, and hooks them up to the new APIs above and below.

7

v1.4

edx-platform#26982 feat: Allow optionally passing PII in course LTI tab

Allows optionally passing the PII in the discussions LTI tab if the above flag is set.

8

v1.4

BE: kewne: Disable changing discussions providers - edx-platform/pull/27825

Disables changing discussion providers once a course run has started unless the user is a global staff.

9

v1.4

xblock-lti-consumer/pull/172

v1.3

Second phase of refactoring the PII Sharing flag

10

v.16

feat: adds additional data and filters to discussions API. cs_comments_service#345

Adds additional filters and data to the cs_comments_service API to drive new features in the discussions MFE.

11

 

Rejected

12

v.1.6

feat: Adds additional data and filters to discussions API edx-platform#27914

Depends upon cs_comments_service#345

Adds new data and filters to the discussions API in edx-platform discussions API based on the above.

13

v1.6

FE: Add topic listing views, post listing view, comment views: frontend-app-discussions/pull/8

Discussions MFE first iteration of UI

14

v1.5

Backend change for TNL-8438

15

v1.3

Backend change for TNL-8339

16

v1.3

Frontend change for TNL-8339

17

v1.5

Frontend change for TNL-8438

18

v1.5

edx-platform#27608 feat: Add REST APIs for course advanced settings and course tabs [BD-38]

Exposes the course advanced settings API and the course tabs API, so they can be accessed through MFEs.

19

v1.6

Adds support for searching all posts to discussions MFE

20

v1.4

UI to enable/disable PII sharing in MFE

21

v1.3

Adds flag to disable changing LTI config for YellowDig (and potentially other providers).

22

v1.4

Return course apps learn more URLs from the backend

23

v1.4

Frontend change for above

24

v1.3

Frontend change for above. Adds message if users can’t edit LTI config, and hides LTI edit UI for them.

25

v1.6

Brings the MFE closer to mockups. Switches fonts etc.

26

v1.4

FE: kewne: Disable changing discussions providers: frontend-app-course-authoring/pull/126

frontend component of above PR.

27

v1.6

FE: Implement add post UI: frontend-app-discussions/pull/6

Frontend - Adds the Add new Post UI for discussions.

28

v1.4

Gives access to course advanced settings allowing course apps like progress to update settings using an API.

29

v1.4

Frontend for editing settings for notes, progress, and wiki

30

v1.6

Small change to include staff / moderator user markers to UI

31

v1.6

Mark posts as read automatically on view after a delay

32

v1.6

Improve URL routing and paths

33

v1.4

Add custom pages card.

34

v1.4

Backend - Adds a data model for course apps API

35

v.1.7

Backend Doc - ADR for in-context discussions

36

v1.6

Just updates dependencies and updates some of the code to match frontend template application

37

v1.6

Use TinyMCE editor

38

v1.6

Adds tests for the data layer, moves the normalisation to the thunk etc.

39

v1.7

ADR for how to access discussion embed links from MFE.

40

v1.4

UI to edit team sets

41

v1.6

Adds a new dropdown for posts and comments that automatically populates valid actions based on permissions and the available editable fields.

42

v1.6

Replaces custom sanitising logic with the bleach library for XSS protection

43

v1.6

Adds editor for replies

44

v1.6

Add support for paginating comments in a post/thread.

45

v1.4

Make wiki configurable

46

v1.6

Add support for certain operation currently not allowed by the discussions REST API.

47

v1.4

Make it possible to enable/disable the wiki

48

v1.4

Implements feedback from TNL-8730

49

v1.6

Add support for questions

50

v1.6

Add support for paginating comments in comments.

51

v1.5

Teams page styling fixes

52

v1.6

Adds support for loading posts on scroll.

53

v1.4

Updated design of custom pages, and only include custom tabs in UI.

54

v1.6

Add support for returning thread counts for topics to cs_comments_service

55

v1.5

Fix for TNL-8820

56

v1.6

Uses above PR to adds support for thread counts to edx-platform APIs.

57

v1.4

ADR for mechanism to enable/disable teams

58

v1.5

Teams setting UX fixes #3

59

v1.5

Fixes the notes tab not showing up.

60

v1.7

Create new discsussions settings for the new experience. Store discussions settings in course.

Refactor the discussion settings API to work from studio and modify modulestore content.

61

v1.6

Implements new filter bar and updates UX to bring it closer to new mockups

62

v1.7

Frontend change for above

63

v1.5

Implements “ADR for mechanism to enable/disable teams”

64

v1.6

Add support for getting anonymous post settings for existing posts and new ones.

65

v1.6

Add the ability to select a cohort when posting a comment

66

v1.6

Tests for action dropdown

67

v1.6

Tests for home component

68

v1.6

Adds a new image upload endpoint for discussions for use with TinyMCE.

69

v1.6

TinyMCE improvements

70

v1.6

Tests for topics

71

v1.7

Adds a new field to units to mark them as discusssable. Will be used in case of custom visibility.

72

v1.6

Show cohort info in posts UI

73

v1.5

Switches view live button to use learning mfe link.

74

v1.7

Add support for hooks and signals to maintin discussoin topic links in the database.

75

v1.7

https://github.com/edx/edx-platform/pull/29259

Hide the UI to add a discussion block if the course is not using the legacy provider

76

v1.6

Hooks up the anonymous posting support

77

v1.6

Add topic link to course structure

78

v1.5

Refactors and updes the tab ordering code.

79

v1.6

Add a waffle flag to show discussions MFE in-context and link the Discussions tab to it.

80

v1.6

Adds new breadcrumb bar

81

v1.9 v1.10

Add a new API that returns user stats.

I asked for early fedback on this and was suggested by Dave Ormsbee that we should test this in a small way in produciton and check the performance that way since evaluating the performance any other way would be hard.

82

v1.7

Add support for smaller screens and in-context embedded views.

Needs tests, and will need to be updated for the breadcrumbs work but is otherwise done.

83

v1.6

Added a user privilige and role infomration to dicussions API.

84

v1.7

Adds discussion context to course blocks API

Depends on

85

v1.6

Completes supports from cohorts

86

v1.6

Fix autosaving

87

v1.9 v1.10

Adds APIs to cs comments service to get comments filtered by user id and course id instead of thread.

88

v1.6

Fixes the topic counts in the topics page

89

v1.6

Redirects to the all posts page when searching posts

90

v1.6

Fixes some of the redirects that broke when swichint to discussionPath

91

v1.6

Bug fix

92

v1.9 v1.10

Adds suports for getting comments by a specific user.

93

v1.6

Remove /discussions from the MFE path.

94

v1.6

Remove /discussions from the MFE path.

95

v1.6

Fixes a bug with the MFE where switching between posts doesn’t clear the comment list, causing comments to pile up.

96

v1.11 v1.12

Content editing and post closing reason codes support in cs_comments_service

97

v1.6

Upgrade banner and experience switcher for discussions

98

v1.7

Split discussions endpoint

99

v1.7

Studio UI for enabling/disabling discussions

100

v1.9 v1.10

New mechanism and API for course user stats

101

v1.6

Delete confirmation

102

v1.7

Needs additional implementation in the PR

New Discussions topic API

103

v1.7

Implementation of ADR in #9

104

v1.9 v1.10

 

edx-platform API for .

105

v1.6

Small PR to hide the feedback button unless configured and only show it with the MFE as discussed in the meeting.

106

v1.7

Fix issue with discussion settings not being saved for new providers

107

v1.6.1

 

108

v1.6

Fixes the bug where new replies don’t show up.

109

v1.6.1

Independent scrolling for discussion UI panels

110

v1.7

Adds supports for new discusion configuraiton options.

Depends on

Depends on

111

v1.7

Adds provider info to API, needed for PR 25 above

112

v1.6.1

Renames the providers to remove new an legacy labels

113

v1.7

Adds support for new topics API to MFE

Depends on:

114

v1.11 v1.12

Recreates the reverted PR but makes the user id optional allowing it to work without changes to the legacy UI.
waiting on an internal review from open craft.

115

v1.9 v1.10

Flag for learners tab

116

v1.7

ADR for keeping context for deleted units in discussion topics.

117

v1.7

In-context discussions sidebar in learning MFE.

Posted here for early feedback. Will probably also need feedback from learnign MFE team.

 

This PR is approved by infinity.

118

v1.6.1

Fixes for following filter

119

v1.6.1

Fixes for the post type filter

120

v1.11 v1.12

edx-platform API for content editing codes.

has merged so this is good to review.

121

v1.6.1

Fixes an error when the related link tries to load the learning MFE inside an iframe in the LMS discussion tab.

122

v1.6.1

Clears the TinyMCE draft saved in localstorage when a content is saved.

123

v1.11 v1.12

API for reason codes

124

v1.6.1

Updates icons

125

v1.6.1

 

126

v1.6.1

 

127

v1.6.1

Automatically resize learning MFE iframe when content is loaded

128

v1.7

API to close sidebar related to PR #10.

This PR is complete but might need to be updated based on PR 10.

129

v1.12

UI for post edit reason codes

130

v1.6.1

Makes the LMS also dyanmically resize the iframe and update URL on navigation.

131

v1.6.1

Uses postmessage to keep the learning MFE and LMS in sync with navigation.

Neds to be used with to test on learning MFE and the PR below for LMS

132

v1.9

Adds a new API to update user stats for existing course

133

v1.9

Adds management command that uses above API

134

v1.6.1

Adds a discussions tab to learning MFE

135

v1.6.1

If the new topic structure is enabled, use the discussion tab in the learning MFE.

136

v1.7

Update discussion events to include new context data

137

v1.12

Accept the editing user and closing use separately so they can be specified separate from the post/comment author.

138

v1.12

edx-platform change for the above

139

v1.6.1

 

140

v1.6.1

 

141

v1.9 v1.10

 

142

v1.9

 

143

 

 

144

v1.7

For deleted topics show them in a new archived section.

145

 

Fixes sorting for course stats

146

 

 

147

1.7

Change the conditions for showing the new provider.

148

1.7

 

149

1.7

 

150

1.7

 

151

1.7

 

152

1.7

 

153

1.7

Add support for sorting by last activity.

154

v1.7

When creating discussion topic links, also store the unit, section and subsection names so they are available when content is deleted.

155

1.7

 

156

1.7

 

157

1.7

 

158

1.7

The edx-platform change for

159

1.7

 

160

1.7

 

161

1.7

 

162

1.7

 

163

1.6

 

164

1.6

A previous PR in cs comments service had a bug that caused certain combination of parameters to not work.

165

1.6

This needs to be test on Stage before deploying to production.