2023-05-19 Meeting notes

 Date

May 19, 2023

 Participants

  • @Viktor Rusakov

 Goals

  •  

 Discussion topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

 

RG updates

 

  • Our first sprint is over

    • Almost all issues are closed except for @Viktor Rusakov 's ones

    • Waiting for design review for clickable Cards PR from @Adam Stankiewicz before merging

    • blocker with typescript config, details in the agenda item below

  • Added some issues to the next sprint, @Peter Kulko already started working on them / done some of them

  • Multiple fixes to the Form.Autosuggest component to the bugs that were raised in wg-paragon slack channel

  • Synced alpha branch with master (there are already new conflict now though)



Commitlint issue with adding typescript config



After extending @edx/typescript-config commintlint github action started failing with

This is an upstream bug with commitlint action that edx repos use and it hasn’t been fixed yet. see https://github.com/conventional-changelog/commitlint/issues/3256and https://github.com/wagoid/commitlint-github-action/issues/560

tl dr: commitlint for some reason tries to read / validate tsconfig.json file, sees that we extend @edx/typescript-config but can’t find it in node_modules since we don’t install dependencies during this action, as a result it trows an error.
Temporary solution taken from the issues above is to delete tsconfig.json before running commitlint. It works for now, see this commit, but requires overriding default commitlint action from openedx org, not sure if that’s ok

Other repos will suffer from the same issue, so we probably need to somehow fix that in openedx org action.

 

 

 

 

 Action items

 Decisions