2023-08-11 Meeting notes

Owned by Vladyslav Zadorozhnii
Last updated: Aug 11, 2023 by Adam Stankiewicz

 Date

Aug 11, 2023

 Participants

  • @Adam Stankiewicz

  • @Vladyslav Zadorozhnii

  • @Peter Kulko

 Goals

  •  

 Discussion topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

 

Open PRs

@Vladyslav Zadorozhnii

Open PRs
https://github.com/openedx/paragon/pull/1498 Multiselect
There was requirements to create design for Multiselect . Any progress?

  • Dark theme variant?

  • Need to check-in with Gabe + Chip designs (blocking implementation to resolve Chip as currently implemented).

    • Should be design’s highest priority with Paragon backlog.


https://github.com/openedx/paragon/pull/2013 table of content

[Adam] Reviewed.


https://github.com/openedx/paragon/pull/1911 Pagination component


Define Types

[Adam] Reviewed.

we continue rebasing sync?

 

Skeleton fix

 

 

SCSS flags

@Vladyslav Zadorozhnii

  • what are the steps to inform community?

    • [Adam] Example:

    • [Adam] I can take this on as an action item so you can stay focused on implementation.

  • and for places where some flags are used like this, do we open PR? In this case flag is used in brand-edx.org and it is $enable-shadows: true !default; so it means we go to brand-openedx and override all shadows to none , like:

# on the top of _variables.scss :root { --pgn-elevation-box-shadow-centered-5: none; --pgn-elevation-box-shadow-centered-4: none; --pgn-elevation-box-shadow-centered-3: none; and so on ... }

Maybe I am missing something…

[Adam] brand-openedx repo itself will continue to not define any custom design tokens; instead, it acts as a template for brand authors to clone/create their own brands. Since Paragon’s default SCSS has $enable-shadows: false, we should continue to adhere to that and ensure no tokens defined in the Paragon repo has shadows configured. That said, we should ensure any shadows are applied for brand-edx.org repo.

 

Migration docs + suggestion for CLI update to incapsulate commands for migration

@Vladyslav Zadorozhnii

Updated docs a bit

 

New issues

@Peter Kulko

[ADAM] GREAT CATCH! YES.


 

Brand and *-header/footer PRs

@Vladyslav Zadorozhnii @Peter Kulko

  • OpenEdx Frontend-component-header -

  • OpenEdx Frontend-component-footer -

  • Edx Frontend-component-header -

  • Edx Frontend-component-footer -



PRs:

.gitkeep add to empty directories

 

Buttons standardization for both themes for alpha

@Peter Kulko

Edx.org



 Action items

 Decisions