2021-09-23 Meeting notes

Date

Sep 23, 2021

Participants

  • @Gabriel Weinberg

  • @Hilary Gordon (Deactivated)

  • @Amy Gershman

  • @Jeff Witt (Deactivated)

  • @Eugene Kang

  • @Jennifer Gregory

  • @TJ Tracy (Deactivated)

  • @Kavya Basu

  • @Bronwyn Hawkins (Deactivated)

  • @Michael Leary

  • @Ben Warzeski (Deactivated)

  • @Ken Clary (Deactivated)

  • @Adam Stankiewicz

Goals

  •  

Discussion topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

10

Selectable box component proposal

@Hilary Gordon (Deactivated)

  • Review component in Figma

  • Discuss next steps

  • Notes from the group:

    • Is card only supposed to be for tiled elements?

    • There is a ticket in PAR backlog for clickable card…but it is a variant of the card component

    • Seems like the card has some specifics about spacing and tiling, does this have that

    • Needs to support a spacing POV

    • Is it a variant of the card, or it’s own thing, implementation wise

    • If anything is really different form the card, it might be need to be it’s own component

    • since it’s a form element, it does have some differences in how the card is use, like error handling and a11y

    • Is there a way to enforce the non-clickable-ness?

      • Not really

    • Jeff; Not good to have clickable elements inside the card

    • Jenn: Some use case could use a link, there may be future use cases.

    • A variant could be created if the selectable box needs to include a link or something clickable

    • Two a11y concerns, focus confusion with the box and elements clickable within it, will throw warnings. new click target minimum sizes, it needs clearance 24x24px. No objection to multiple actions…but we should not show focus on the card itself if there are clickable thing

    • Adam S: If there is no radio button or input field, is there concern from a11y POV? Jeff: Make it the same selectable element, but just hiding the element is fine

remaining time

Data table enhancement, toggle view component

@Jennifer Gregory

Notes:

  • Where does this live in the component?

  • Does the icon button have an active state? Technical questions

  • Any feedback about how this is fitting in, repsonsive behavior?

  • Concern: in the case where it is supporting both view and card view, if there is ability select rows in the table view, can you still select cards or do you lose that capability? We would lose sorting and selection capabilities.

    • Starting use case, no selectable items or sorting

    • Can iterate if the use case becomes challenging

  • Icon button: can we use the icon button and an active state.

    • Not currently supported, but we can tack that onto the work.

  • Background color, you can use inverted colors, check the documentation

  • Popover should be tool tip instead, for hover instead of click

  •  

Action items

@Hilary Gordon (Deactivated) Clarify spacing for the card. Cards are used in isolation, but this does inehrent spacing, we need that built in as a spec
@Gabriel Weinberg@Hilary Gordon (Deactivated) create PAR board ticket in JIRA
@Jennifer Gregory clarify selectable and sortable functionality of the table in card view. Create ticket in PAR board

Decisions

  1. Selectable Card component is a distinctly different component compared to the standard card component
  2. Selectable Card component should not have clickable elements within it for the MVP..only the card itself should be clickable, have focus, show an error state. Revisit if the need grows or becomes challenging
  3. @Jennifer Gregory Toggle switch for Data Table can be put into PAR JIRA, just note if there are any additional specs details that werent discussed live in PWG