2023-07-06 Frontend Working Group Meeting Notes

 Date

Jul 6, 2023

 Participants

  • @Adolfo Brandes

  • @Pedro Martello

  • @Fox Piacenti

  • @Jesper Hodge

  • @Ghassan Maslamani

  • @Jason Wesson

  • @Muhammad Abdullah Waheed Khan

  • Katrina

  • @Brian Smith

  • @Max Frank

Recording

Please be advised: Frontend Working Group meetings are recorded.

 Discussion topics

Time

Item

Presenter

Notes

Time

Item

Presenter

Notes

5

“@openedx” NPM packages

@Adolfo Brandes

https://github.com/openedx/axim-engineering/issues/806

  • Redirect? Not sure if possible

  • If not, @Brian Smith suggests just publishing the new versions in the new namespace, keeping the old ones there

20

Update on Piral and Modular MFEs

@Pedro Martello

  • Discovery should wrap up this week

  • Refer to frontend-app-shell for installation instructions (temporarily in Pedro’s repository, will move to the openedx org this week)

5

Enzyme deprecation discussion

@Muhammad Abdullah Waheed Khan

Should we fully remove enzyme or use the adapter react-unit-test-utils

  • It makes sense to use the current industry standard (React Testing Library): it’s just likely to be more time-consuming to rewrite the existing tests to it. However, FED-BOM would still prefer to use RTL, and since they’re going to do the brunt of the work across the frontend repositories, there were no objections.

  • Some repositories - likely the ones owned by Aurora - will use react-unit-test-utils, but that’s also ok. One of the reasons to have MFEs in the first place is to give code owners some freedom in decisions of this kind.

10

Unit vs Integration tests

 

  • Unit tests are a way to document what the code should do and also speed up development iteration, so they should definitely not go away

  • Integration tests are valuable too, but one does not exclude the other

  • Ideally tests are written using both techniques where they’re best applicable

 Action items

 Decisions