2024-03-21 Meeting notes

Start Recording

edx-platform assets

@Kyle McCormick

• [DEPR]: Asset processing in Paver · Issue #31895 · openedx/edx-platform

  • See latest comment on that for details

  • I will test with themes: default, tutor-indigo, maybe edx.org-next if I still have a copy

  • I will send out the branch as soon as it’s ready so that folks can test out their private themes ahead of time.

edx-platform write access

@Kyle McCormick @Jeremy Ristau

• Teams in CODEOWNERS require write access. That means that if we want to use CODEOWNERS to list edx-platform app maintainers, we would need to grant write access to every listed maintainer.

  • Possible workarounds

    • Instead of listing a team, list the leader/manager of that team

    • Instead of listing a team, list an edx-platform CC on the team. This, obviously, requires that at least one member of the team be a CC on edx-platform, but maybe that’s OK?

    • Just give the repo write access to the whole team. How would that work with the CC program?

    • Require reviews from CODEOWNERS. This would limit write access of everyeone in the repo to the CODEOWNERS list.

      • We would need to grant write access to edx-platform CCs in codeowners as well.

    • Avoid this issue--don’t use CODEOWNERS to manage app maintainers. Use something else.

• We don’t need to figure this out now. Revisit once Redwood upgrades cool down.

Start Recording

edx-platform Python Upgrade

@Feanil Patel

• Python 3.11 instead of 3.12

• Numpy and SciPy Upgrade

  • No Numpy that supports both Python 3.8 and Python 3.12

    • Means that we need to target 3.11 instead of 3.12 for edx-platform

  • Both Numpy and scipy are in edx-sanadbox (codejail env)

    • JB: We’ve had separate requirements files to smooth transitions

      • Feanil: Yes

      • We could upgrade edx-sandbox to 3.11 for Redwood, but 2U and others could fall back to the 3.8 sandbox for a while if they need to

      •  

  • Will impact 2U earlier as it lands on master.

Still need folks to pick

up python 3.11/12 upgrade work

• Update all Python Libraries to Test on Python 3.11 and 3.12 · Issue #233 · openedx/public-engineering

Should 2U PRs go to the Contributions Board?

@Michelle Philbrick

• For repos where they are not the maintainers, that’s a fine way to get them reviewed.

• This came up when Adolfo pointed out that a certain PR authored by a 2U employee needed some product review. Question became “what’s the process here?” How do they get that product review?

• If we tracked 2U contributions on the board as well as everyone else’s, that would add a lot of weight to the contributions board process.

• Feanil: Ideally we’d have more people helping with the contributions board.

• For the time being, leave it up to 2U owners to get product review.

• Michelle: The change should already be on Jenna’s product review board, so we shouldn’t need to add it to the contributions board.

• Feanil: Still, there will be 2U PRs that are blocked by code review on repos they don’t have write access to. In other words, there will be more OSPRs, and our process will need to adapt

• Robert: If we have a single 2U PR that is blocked by community code review, could that single PR get onto the contributions board, without ALL 2U PRs going there now.

• Michelle: Tim is maxed out w.r.t. time spent managing the contributions board, Michelle nearly is as well, the process can’t handle more PRs right now

• Tim: Back in the maintainership pilot days, we’d said that the contributions board would eventually go away (or at least not need manual management), because maintainers would be able to manage incoming PRs.

• Michelle: Would that ^ process have a way for people to look in order to figure out who is going to review their PR?

• Adolfo: Maintainers should be running this process

• Tim: We need some way to automatically tell people who their reviewer should be. Some sort of automation, looking at catalog-info.yml, or linking to backstage

• Feanil: We should start scaling down the contributions board, perhaps by removing repos that are maintained?

• Feanil: We should recruit a 3rd person to help Tim and Michelle