2024-07-25 Meeting notes

Customizing the header and footer for MFEs

@Adolfo Brandes

• lot of slots targeted for sumac

  • we’ll have a priority list

  • header first priority, then footer

• we know that we’ll have these slots, and we know we want to DEPR the old way of doing things. when do we announce the breaking change?

  • Maybe just wait until OEP-65, post-sumac

  • sounds like we’re signing up to keep the old way working for a bit until the new way has landed

  • brian would prefer depr’ing forking the footer sooner than later. we have the footer slot, can we push people towards that now? it would get people on the right path.

  • decision: will DEPR forking the header and footer

    • sumac will support it, it’ll be unsupported in teak

• also an ongoing conversation on doing frontend plugins better – eg, plugins owning the configuraiton rather than env.config.js owning it. See frontend-wg notes for more info.

•  

PyPI Publish GH Action Update

@Feanil Patel

• Please review sub-tickets of PyPI Publish Github Action Master Branch Sunset · Issue #270 · openedx/public-engineering if you can, please review and merge.

  • the publishing github action doesn’t support being run from master any more

  • Emad has made PRs to switch to named actions

  • Maintainers pls review and merge over the next couple months

• Robert: is there a place where mainainers can watch for these things?

  • Feanil: Subscribe to “Maintainers > Announcements”

Hand off of Node 20 upgrade to Brian Smith

@Adolfo Brandes

• Brian S is taking over node 20 upgrade

• Go over the merge to master procedure

  • Adolfo: What warning/approval is needed from 2U in order to merge these upgrade PRs?

  • Feanil: This first step is to just add Node 20 support, since that is additive, we shouldn’t need 2U’s approval

    • tutor will switch to node 20 once support is added

    • nvmrc won’t be switched to node 20 until we are ready to drop node 18 support

    • Adolfo: We should start by having the Node 18 vs 20 test matrix, making Node 20 optional at first, so you know which repos have Node 20 working. Then get Node 20 working, then drop Node 18 support.

    • Brian S: What to have in nvmrc? Use whatever you want package-lock.json to be ge

      • In the odd edge case where we can’t have both versions running at the same time, then it’ll be different. we expect this on a few MFEs.

    • Robert: just clarifying, the backwards incompat step is the change the package-lock.json?

      • yes

      • More precisely, this is the breaking change:

        • nvmrc: 18->20

        • package-lock.json: generate with 20

        • drop Node 18 tests

    • We need to be Node 20 compatible by Sumac. We will remain Node 18 compatible for Sumac wherever possible. In Dec/Jan, at the 6-month depr acceptance mark, that’s when we drop Node 18 support

    • Reference, the 6-month pilot we are doing for DEPRs: Pilot: Use the DEPR process for breaking changes · Issue #595 · openedx/open-edx-proposals

      • How do we handle multiple dates?… tbd

    •  

• seems like we had more attendees last week. Is this a bad time?

  • could just be an August thing

  • Feanil will pre-announce the next meeting to see if we can get more heads

edx-platform meeting

“Big Changes to edx-platform” → “edx-platform Arch Roadmap”

@Kyle McCormick

[Draft] edx-platform Architectural Roadmap · Issue #35144 · openedx/edx-platform

API DRF Conversion

Awais Q/Feanil

Migrating LMS APIs to DRF · Issue #35057 · openedx/edx-platform

Awais is working through these, and at least one community member has stepped up to help. If you are interested please feel free to jump in with implementation or review.

Robert: will there be backwards incompat changes? even minor ones like a 401 becoming a 403?

• Feanil: for this first conversion, based on the unit tests, the APi stayed the same

• Feanil: If/when an API endpoint is broken by converting to DRF, we’ll need to use the DEPR process

• Testing for regressions?

  • Awais has been manually testing, including error codes. Has not changed existing unit tests.

  • Awais will check headers going forward

  • Feanil: Write test steps down in PR

• Parallelization

  • Awais will help that one volunteer so far

  • After a few more PRs we can probably solicit more help from CCs

  • Awais will put a how-to on the wiki

  • good-first-issue ? Not yet, but once the how-to is more fleshed out, that could be good

  • Fea

Django 5.1?

• aximprovements is currently turning the warnings into tickets

• which will let us get more good-first-issues for fixing those

• Teak timeline

  • 4.2 EOL is April 2026