Maintenance Working Group Meeting – 2024/10/24 09:00 EDT – Transcript

Attendees

Adolfo Brandes, Awais Qureshi, Feanil Patel, Feanil Patel's Presentation, Jeremy Ristau, Kyle McCormick, Michelle Philbrick, Robert Raposa

Transcript

Feanil Patel: Yeah. How you doing?

Awais Qureshi: If an interview.

Awais Qureshi: I'm good. You are busy. Last couple of weeks.

Feanil Patel: Yeah. We're having issues with the code jail stuff.

Awais Qureshi: Release. okay.

Feanil Patel: With the release. So as a Very tiny corner of our software but very critical. So I'm spending a lot of time trying to debug how we can upgrade it for the Ubuntu upgrade. But I should be back to reviews now. Much more quickly.

Awais Qureshi: Great great.

Robert Raposa: Was that serving issues for the upgrade that we actually got out the door or for looking into the next one?

Feanil Patel: So we were able to land the 22:04 part of at least.

Robert Raposa: Okay.

Feanil Patel: 

Feanil Patel: But we're still seeing failures on 2404 for coach jail. So there's further. Investigation that needs to happen there.

Feanil Patel: Peace Meeting notes page is coming up now.

Feanil Patel: You should see that. Okay, make a little bigger.

Feanil Patel: Cool.

Feanil Patel: So Kyle, you had this issue for tutor related images. I think that's mostly good now, but confirm.

Feanil Patel: You're talking. I can't hear you.

Robert Raposa: Maybe, okay.

Feanil Patel: can you hear me yet?

Robert Raposa: Are you?

Robert Raposa: I think you need to put.

Feanil Patel: Kyle and Jeremy. Yeah.

Kyle McCormick: Yes, I can hear you.

Feanil Patel: Okay there we go. I would say, Do you have? I think this insurer service images using 22 is good. Now I posted on the forums once the Ubuntu upgrade ticket closed and that would Also confirmed that they acknowledge that in the PRS are in place.

Kyle McCormick: Yep. it been on it and…

Feanil Patel: but, I'm gonna.

Kyle McCormick: we have I think one or two peers remaining to review.

Feanil Patel: That, okay, so Mark, that is done. Haven't been able to do the update from the Elasticsearch or the cron ticket, but I'm hoping that now that the code jail stuff is sufficiently at the door. That an Xbox platform can be upgraded to the 22204. I'm going to start picking some of this back up. and then, Jeremy any updates on planning the front end, stepper work.

Jeremy Ristau: no, not

Feanil Patel: For the studio presentation.

Feanil Patel: All right, and then michelle, you've got a thing and then

Feanil Patel: we do. Santa posted about this latest versus Ubuntu. At a specific version and I have some more information on that. So let's talk about that.

00:05:00

Feanil Patel: That's going on.

Feanil Patel: Various as absolute. We'll talk about that in front part. Okay, let's talk about maintenance.

Feanil Patel: All right, Michelle do you want to start with your github actions? The issue.

Michelle Philbrick: Yeah, this should be quick. There's a bunch of these tickets hanging out on the contributions board.

Michelle Philbrick: A chunk of them are for unmaintained repo. So I was just wondering if there's somebody that I can have. I don't know if they're easy enough to review and merge for someone to take the unmaintained ones. So I figured I'd check here first

Feanil Patel: Yeah. I think you can try to drop them into the park contributor channel as these are all the things that anybody can review because we don't have a clear maintenance for them.

Michelle Philbrick: Okay.

Feanil Patel: And that's probably a good first step and hopefully other CC's can chime in but I can try to pick up some of them. Based on capacity…

Michelle Philbrick: Okay, I'll

Feanil Patel: but yeah, they shouldn't be too complicated. So I think it's a matter of if CC's can approve them, even if they can't merge them, and we have a list of things that are approved that need to be merged. I'm happy to go push that button to sort of Accelerate this while we're trying to get maintenance for all of those repos set up.

Michelle Philbrick: Okay Sounds good. Thank you.

Feanil Patel: So I think that part makes sure it's really clear. we don't expect you to be able to merge everything, but if you can review and verify that it's good to go and put an approval on it, that'll speed up the process of that final review and I can do the final review and merging part.

Michelle Philbrick: Okay, awesome. Thank you.

Feanil Patel: Yeah.

Feanil Patel: But And then the maintenance at large position now exists and people can be nominated for it. so I wanted to sort of circle back with you Jeremy about. I believe that's sufficient and it probably just needs to be integrated into the CC rollout plan stuff. We've been talking about to you.

Feanil Patel: But if there's any other Things to discuss or change or talk about there. I want to make sure we had some space for that.

Jeremy Ristau: I mean, from my perspective, it's a solution to the problem that I brought to you.

Feanil Patel: Yeah.

Jeremy Ristau: So I really appreciate that.

Jeremy Ristau: The proposal seems totally fine. So,

Feanil Patel: All right, then.

Feanil Patel: Yeah, I think we can check in on it after we put Through its paces a bit.

Feanil Patel: So anybody else have any general maintenance issues, I can provide a quick update on the Ubuntu upgrade issue, which I didn't close yesterday. When I do that real quick.

Feanil Patel: so, where we ended up is essentially 2404 is the Ubuntu version for Everything except for EDX platform and one of its dependencies at this point. As far as I know, everything else was running tests on 224, when there is running tests on 2404 now that I'm going to latest points to that without any issues, which in my mind confirms these sort of, os agnosticness of most of our Python and node code, which is great, the places where we have I think some OS specific issues are unsurprisingly EDX platform which has an extremely deep dependency tree as well as

Feanil Patel: Code jail, which has a lot of dependencies on the underlying OS security systems.

00:10:00

Feanil Patel: For the Ubuntu 2204, especially for operators. I want to really highlight that there was a change that needed to happen to go jail for that and they've updated the Readme with that change and link to the relevant commit message where I made the fix. But if you are an operator, who runs code jail in production, You should definitely look at that. Pull request and the relevant notes on discourse. And I can try to find and link to that again, but it was in the maintenance announcements. So the post I made yesterday is

Feanil Patel: yeah.

Feanil Patel: So yeah so I think all in all super good, the note 20 upgrade similarly is a thing. Fully done Adolfo. I believe you you've got the Dr. MFP plug-in running on on note, 20 now.

Feanil Patel: 

Adolfo Brandes: Yeah, that's correct.

Adolfo Brandes: By which, I mean it's on tutor nightly and it'll be on sumac.

Feanil Patel: Yeah. Yeah.

Feanil Patel: Yeah. Similarly, I believe the other two sort of minor upgrades that we have been trying to complete, which were sort of long running from beforehand was enzyme and Most the other Windows enzyme and just I believe were the two upgrades and…

Adolfo Brandes: Yeah.

Feanil Patel: the enzyme upgrade is completed everywhere except for commerce related repos. Which are going to be archived soon. And the just upgrade I believe just upgrades complete everywhere except for the ecommerce Repos. The enzyme upgrade is completed everywhere except for EDX platform. Alex Platform has one enzyme-based test. And so that needs to happen before that's fully done.

Feanil Patel: for the purposes of, I think, most people that's done, but if we had Some front-end resources on the EDX platform side that we could spare that would be a good thing to get over the line so that we're fully out of that. those were long-running upgrades that were in process a year ago when we started this working group, He's trying to get them to close.

Feanil Patel: And I think Those are the big targets we had for Sumac, so I think really awesome. Job on everybody's parts Brian Smith who is not here but who has been leading the new 20 upgrade? Did an amazing job coordinating all of that.

Feanil Patel: and so now, I'm hoping we can find other people to help support the next couple of upgrades Django being the biggest one.

Feanil Patel: Somebody else have any other issues they want to talk through for maintenance.

Feanil Patel: If not, this might be a pretty short meeting today. I know we're trying to cut schemack later today, so,

Feanil Patel: You can just get some time back.

Feanil Patel: What's right? What's up, Jeremy?

Jeremy Ristau: and I just say that.

Jeremy Ristau: The back boundary feels much healthier than the redwood boundary from a maintenance perspective. I'd like to at least knowledge that I think, there was some impact, from this group of people. So Yeah,…

00:15:00

Feanil Patel: Yeah.

Jeremy Ristau: really good. the feature part, that's like a different conversation and I think trying to get features at a boundary is the right thing to be rushing for instead of trying to get maintenance and for the boundary so really awesome.

Feanil Patel: Yeah and I think the enzyme stuff neither of these work in the considered blocking upgrades because they will be fine. It's just not ideal to have long running tasks. So we'll try to get these closed out as soon as we can. But yeah we didn't consider the note in the country, ones were blocking, but we're in a really good shape now because we have a release and a half where we won't have any blocking maintenance work done, which is, I think, The longest we've had in a while where there's not a major thing needed to be landed.

Feanil Patel: One of the other things that we should talk about at some point, but I think there's already other conversations happening is the elasticsearch versus melee a search stuff, which is a bit of a product feature question. But also a bit of a maintenance question because we have so much elastic search in our platform. Would have to talk about it today, but I'm sort of planting a seed that if you haven't been following what's going on with elastic, surgery would be good carve out some time for that because that's probably a question we need to answer given how old the version of elasticsearch we're currently running on is

Feanil Patel: so, Yeah, no, I think we've done a really good job and I am hoping that we can take advantage of this extra time to define work for maintenance without having to sort of, Be on top of them to landed immediately. And the next couple of upgrades go a little bit smoother, that's kind of the next maturity goal in my mind for this group.

Jeremy Ristau: Good stuff.

Feanil Patel: yeah, and hopefully find more maintenance which will have more time for now that we're not 100% focused on getting these major upgrades landed.

Feanil Patel: In that case, I think we should transition to EDX platform related stuff. And anybody who wants to Drop off. Should feel free to do so.

Feanil Patel: And we've got a bunch of topics in that particular.

Feanil Patel: so, we have

Feanil Patel: It done to this person.

Feanil Patel: And we do have timeline with links from Diana, so we can close that. and then,

Feanil Patel: I think that's the only thing to talk about. So yeah. Fine.

Feanil Patel: I looked at the RCA and I looked at I put up another PR just to try to get a better handle on this and There are a couple of different things that happen. One was the way.

Feanil Patel: The way we set up Mongo was OS specific because we had a hard coded URL to the Act repository that the mango binaries live in.

Feanil Patel: This I think of fairly easy solve because there are now Reusable actions that will let us install Mongo and not have to think about that. And I think if we switch to one of those, then we can Not care about what version of Ubuntu we're on, and it will take care of that. and so that sort of moves us more towards reduce maintenance less more agnostic to the OS version but the other big thing was

Feanil Patel: the XML SEC package which It looks like it's used by the one login saml stuff that is. I haven't figured out exactly which package it's part of yet, but I think it's part of the OAuth package that lets you do OAuth with any given provider, but the XML SEC package Relies on a statically linked by Debian package on disk. So when you move OS versions, that has to like the version of the OS package and the version of the Python package, have to match up and align. So that is a place where I think we're in this situation where We can't just rely on automatic upgrade that being fine because it's

00:20:00

Feanil Patel: not resilient, it doesn't seem currently resilient to that. Static length, braking across OS versions. but I need to look into it a little bit further, I just was able to produce the error and start digging into it but to me, that's enough for now to say that we should Do named versions on EDX platform of Ubuntu until we get a better handle on it, or that package improves, how it manages. That link between the static library, and the Python Library.

Feanil Patel: in that, but I kind of want to not run double tests. So I don't want to run the entire suite twice for two different OS versions. So I think this is going to revive A thing we did with Mongo where it's kind of relation.

Feanil Patel: We essentially picked a couple of shards that we would run. Through the old version. Once we got everything passing on the new version to make sure we essentially like smoke tested and didn't break anything, but that we wouldn't run the full test suite on the older version. And if we identify specific tests, that it makes sense to keep on the old version we can. Do that. But

Jeremy Ristau: sounds like awfully Related stuff would make sense.

Feanil Patel: The PRS.

Feanil Patel: Yeah, yeah, but it was like if it's able to pick it up during the install phase, that there's this mismatch. So this one is pretty easy to be as long as any single shard of our tests pass on the old version, we're fine. But for other future cases that we might be like, we need to run this set of unit tests to actually detect it. So let's make sure we're still running those on the old version and the new one. And we may have to sort of maybe a little bit more sort of on the fly figuring out what makes sense. Instead of we always run X on both versions…

Jeremy Ristau: Yeah.

Feanil Patel: but But not running everything I think is the point of discussion that I want to sort of get feedback on

Jeremy Ristau: If I think I'm learning, let's as acceptance as a terrible practice and I'll say, I have no issue fundamentally with what you just described that makes total sense to me. Optimize test running. Yeah.

Robert Raposa: Business. …

Feanil Patel: there.

Robert Raposa: I also agree with Everything that you're approach. Posing is codegel, a third issue here or no? but,

Feanil Patel: Yeah, jails is fully independent issue from this issue.

Robert Raposa: the only thing that's maybe not fully independent, but I don't actually know is Coachella is its own.

Robert Raposa: but EDX platform. Relies on it. It's just making sure that Because the test for EDX platform are run all the time and the test for code gel are not run all of the time. Yeah, so that's the only thing that makes it less independent to me of how do we make sure that we actually know about the code jail issue at the right time?

Feanil Patel: Right.

Feanil Patel: you're saying because We might not see if a thing breaks code jail, when we make a change on the platform side.

Robert Raposa: right. I mean

Kyle McCormick: I don't think anything in the